Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(758)

Issue 2597323002: Object.prototype.toString must reflect mutated @@toStringTag values for primitives (Closed)

Created:
4 years ago by adamk
Modified:
3 years, 12 months ago
Reviewers:
Franzi
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Object.prototype.toString must reflect mutated @@toStringTag values for primitives The TF version of this operation was missing a ToObject coercion, so failed to do @@toStringTag lookups when passed primitive values. R=franzih@chromium.org BUG=v8:5780 Review-Url: https://codereview.chromium.org/2597323002 Cr-Commit-Position: refs/heads/master@{#41961} Committed: https://chromium.googlesource.com/v8/v8/+/23019c4ec0773f6e7a02dd8c3c30666d68f59bea

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -39 lines) Patch
M src/builtins/builtins-object.cc View 5 chunks +34 lines, -39 lines 0 comments Download
A test/mjsunit/regress/regress-5780.js View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
adamk
4 years ago (2016-12-22 22:20:37 UTC) #1
Franzi
lgtm, thanks for spotting this bug. Happy Holidays :)
3 years, 12 months ago (2016-12-23 08:39:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2597323002/1
3 years, 12 months ago (2016-12-27 17:32:43 UTC) #8
commit-bot: I haz the power
3 years, 12 months ago (2016-12-27 17:57:42 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/23019c4ec0773f6e7a02dd8c3c30666d68f...

Powered by Google App Engine
This is Rietveld 408576698