Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 2597193003: Enable iframe support for web payments by default. (Closed)

Created:
4 years ago by please use gerrit instead
Modified:
4 years ago
Reviewers:
Rick Byers
CC:
chromium-reviews, blink-reviews, kinuko+watch, zkoch1, domenic, foolip, iclelland
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable iframe support for web payments by default. Intent to implement and ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/vM3RM1OQNFU/ao3wqCM6AgAJ BUG=652148 Committed: https://crrev.com/60fc664d00a1b25f327e5b382d4beb473f5eddc4 Cr-Commit-Position: refs/heads/master@{#440565}

Patch Set 1 #

Patch Set 2 : allowpaymentrequest attribute available only if PR is enabled #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -10 lines) Patch
M third_party/WebKit/Source/modules/payments/HTMLIFrameElementPayments.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/payments/HTMLIFrameElementPayments.idl View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentRequest.cpp View 1 2 chunks +3 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 18 (11 generated)
please use gerrit instead
Rick: ptal.
4 years ago (2016-12-22 20:38:15 UTC) #4
Rick Byers
Won't HTMLIFrameElement.prototype.allowPaymentRequest be enabled by default everywhere with this (and so you should get webexposed ...
4 years ago (2016-12-22 20:55:11 UTC) #5
please use gerrit instead
Excellent point! Fixed. PTAL.
4 years ago (2016-12-22 21:06:54 UTC) #8
Rick Byers
LGTM
4 years ago (2016-12-22 21:54:29 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2597193003/20001
4 years ago (2016-12-22 22:49:12 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-23 00:50:12 UTC) #16
commit-bot: I haz the power
4 years ago (2016-12-23 00:52:56 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/60fc664d00a1b25f327e5b382d4beb473f5eddc4
Cr-Commit-Position: refs/heads/master@{#440565}

Powered by Google App Engine
This is Rietveld 408576698