Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2597173002: [turbofan] Continue collecting CallIC feedback in optimized code. (Closed)

Created:
4 years ago by Benedikt Meurer
Modified:
4 years ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Continue collecting CallIC feedback in optimized code. Similar to Crankshaft use the CallIC to continue gathering feedback for uninitialized call sites instead of inserting a soft deopt. R=mvstanton@chromium.org Review-Url: https://codereview.chromium.org/2597173002 Cr-Commit-Position: refs/heads/master@{#41927} Committed: https://chromium.googlesource.com/v8/v8/+/b0ff71dbe83afa00597a920dda560c765444932f

Patch Set 1 #

Patch Set 2 : Fix some tail calls. #

Patch Set 3 : Tail calls are very, very broken in TF. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -20 lines) Patch
M src/compiler/js-call-reducer.h View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M src/compiler/js-call-reducer.cc View 1 2 2 chunks +27 lines, -15 lines 0 comments Download
M src/compiler/pipeline.cc View 1 2 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 19 (13 generated)
Benedikt Meurer
4 years ago (2016-12-22 10:50:58 UTC) #1
mvstanton
neat! lgtm
4 years ago (2016-12-22 10:53:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2597173002/1
4 years ago (2016-12-22 10:58:13 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/builds/10191) v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
4 years ago (2016-12-22 11:16:13 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2597173002/40001
4 years ago (2016-12-22 18:03:09 UTC) #16
commit-bot: I haz the power
4 years ago (2016-12-22 18:27:52 UTC) #19
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/b0ff71dbe83afa00597a920dda560c76544...

Powered by Google App Engine
This is Rietveld 408576698