Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Issue 2597083002: Moved list-style-type to be generated in ComputedStyleBase (Closed)

Created:
4 years ago by sashab
Modified:
4 years ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-layout_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, rwlbuis, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moved list-style-type to be generated in ComputedStyleBase Move the inherited property list-style-type and its enum, EListStyleType, to be generated in ComputedStyleBase. Also moved getter / setter / initial value methods to be generated in ComputedStyleBase. Also renamed some of EListStyleType's values to be consistent with the keyword values for list-style-type: DecimalListStyle -> Decimal CJKIdeographic -> CjkIdeographic NoneListStyle -> None Since they are now inside an enum class, they cannot be used without the EListStyleType:: prefix, so they are safe to use simple names for. Committed: https://crrev.com/3a0ac152a1fd539092426226e317ef96c6549afd Cr-Commit-Position: refs/heads/master@{#440339}

Patch Set 1 #

Messages

Total messages: 13 (8 generated)
sashab
4 years ago (2016-12-22 02:27:23 UTC) #4
alancutter (OOO until 2018)
lgtm
4 years ago (2016-12-22 03:15:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2597083002/1
4 years ago (2016-12-22 03:16:10 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-22 04:32:58 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-22 04:34:59 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3a0ac152a1fd539092426226e317ef96c6549afd
Cr-Commit-Position: refs/heads/master@{#440339}

Powered by Google App Engine
This is Rietveld 408576698