Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 2597013005: Revert of Enable BrowserScheduler.RedirectHistoryService experiment on trunk. (Closed)

Created:
4 years ago by hcarmona
Modified:
4 years ago
Reviewers:
gab, rkaplow, sky
CC:
chromium-reviews, fdoray
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable BrowserScheduler.RedirectHistoryService experiment on trunk. (patchset #6 id:120001 of https://codereview.chromium.org/2592813002/ ) Reason for revert: Suspecting this CL of causing test failures: ProfileBrowserTest.CreateNewProfileSynchronous ProfileBrowserTest.OffTheRecordURLRequestContextIsolation ProfileBrowserTest.CreateOldProfileSynchronous ProfileBrowserTest.ExitType b/c error messages mention HistoryBackend https://uberchromegw.corp.google.com/i/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/25845 Original issue's description: > Enable BrowserScheduler.RedirectHistoryService experiment on trunk. > > Add .WithSyncPrimitives() trait to history service's backend > TaskRunner. Required by ChromeHistoryBackendClient::IsBookmarked(). > > BUG=661143 > TBR=sky@chromium.org (history_service.cc tweak to experiment) > > Committed: https://crrev.com/4aa30591e0953da7e0c54ffdb91856e496d16b5f > Cr-Commit-Position: refs/heads/master@{#440418} TBR=rkaplow@chromium.org,sky@chromium.org,gab@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=661143

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M components/history/core/browser/history_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M testing/variations/fieldtrial_testing_config.json View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
hcarmona
Created Revert of Enable BrowserScheduler.RedirectHistoryService experiment on trunk.
4 years ago (2016-12-22 19:43:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2597013005/1
4 years ago (2016-12-22 19:44:12 UTC) #3
commit-bot: I haz the power
Failed to apply patch for testing/variations/fieldtrial_testing_config.json: While running git apply --index -p1; error: patch failed: ...
4 years ago (2016-12-22 19:44:43 UTC) #5
gab
4 years ago (2016-12-22 19:54:04 UTC) #6
On 2016/12/22 19:44:43, commit-bot: I haz the power wrote:
> Failed to apply patch for testing/variations/fieldtrial_testing_config.json:
> While running git apply --index -p1;
>   error: patch failed: testing/variations/fieldtrial_testing_config.json:212
>   error: testing/variations/fieldtrial_testing_config.json: patch does not
apply
> 
> Patch:       testing/variations/fieldtrial_testing_config.json
> Index: testing/variations/fieldtrial_testing_config.json
> diff --git a/testing/variations/fieldtrial_testing_config.json
> b/testing/variations/fieldtrial_testing_config.json
> index
>
bb6a3247d1e02b4a31f83c42901571999e76ff78..dd6bbd7a76c882be733967e0c8fe78ba25b3062f
> 100644
> --- a/testing/variations/fieldtrial_testing_config.json
> +++ b/testing/variations/fieldtrial_testing_config.json
> @@ -212,10 +212,7 @@
>              ],
>              "experiments": [
>                  {
> -                    "name": "Default",
> -                    "params": {
> -                        "RedirectHistoryService": "true"
> -                    }
> +                    "name": "Default"
>                  },
>                  {
>                      "name": "EnableViaFlag",

Rebased on trunk and landing in https://codereview.chromium.org/2598033003

Powered by Google App Engine
This is Rietveld 408576698