Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2597013004: [ic] Always use generic ICs for growing element stores on arguments (Closed)

Created:
3 years, 12 months ago by Camillo Bruni
Modified:
3 years, 12 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ic] Always use generic ICs for growing element stores on arguments In certain corner-cases we would grow a FAST_ELEMENTS packed backing store of a JS_ARGUMENTS_TYPE object without converting to holey elements kinds. As a side effect you could then read out the_hole. BUG=v8:5772 Review-Url: https://codereview.chromium.org/2597013004 Cr-Commit-Position: refs/heads/master@{#41921} Committed: https://chromium.googlesource.com/v8/v8/+/f73973092c780ba6c2c6988fce777472eb95a58f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -10 lines) Patch
M src/ic/ic.cc View 2 chunks +4 lines, -7 lines 0 comments Download
M src/objects.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects-inl.h View 2 chunks +4 lines, -3 lines 0 comments Download
A test/mjsunit/regress/regress-5772.js View 1 chunk +42 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Camillo Bruni
PTAL
3 years, 12 months ago (2016-12-22 14:06:37 UTC) #6
Igor Sheludko
lgtm
3 years, 12 months ago (2016-12-22 14:08:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2597013004/1
3 years, 12 months ago (2016-12-22 14:09:18 UTC) #9
commit-bot: I haz the power
3 years, 12 months ago (2016-12-22 14:11:01 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/f73973092c780ba6c2c6988fce777472eb9...

Powered by Google App Engine
This is Rietveld 408576698