Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 2597003002: Re-enable the omitted tests in path_builder_unittest.cc. (Closed)

Created:
4 years ago by eroman
Modified:
3 years, 11 months ago
Reviewers:
mattm
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable the omitted tests in path_builder_unittest.cc. This also fixes a problem introduced by 994db999829331ea3b982d9c9ec469fde22de21d. BUG=649017 Review-Url: https://codereview.chromium.org/2597003002 Cr-Commit-Position: refs/heads/master@{#443184} Committed: https://chromium.googlesource.com/chromium/src/+/19f85676701186e6ac1de7c625fffcab4a83d701

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -96 lines) Patch
M net/cert/internal/path_builder.cc View 3 chunks +9 lines, -7 lines 0 comments Download
M net/cert/internal/path_builder_unittest.cc View 11 chunks +43 lines, -89 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
eroman
4 years ago (2016-12-22 00:06:08 UTC) #4
mattm
lgtm
3 years, 11 months ago (2017-01-11 23:39:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2597003002/1
3 years, 11 months ago (2017-01-12 02:13:12 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/263264) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
3 years, 11 months ago (2017-01-12 02:24:39 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2597003002/1
3 years, 11 months ago (2017-01-12 07:23:43 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 08:20:50 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/19f85676701186e6ac1de7c625ff...

Powered by Google App Engine
This is Rietveld 408576698