Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issue 2596983002: Convert audiobuffersource-playbackrate to testharness (Closed)

Created:
4 years ago by Raymond Toy
Modified:
3 years, 11 months ago
Reviewers:
hongchan
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert audiobuffersource-playbackrate to testharness Manually convert test to use testharness BUG=676394 TEST=audiobuffersource-playbackrate.html Review-Url: https://codereview.chromium.org/2596983002 Cr-Commit-Position: refs/heads/master@{#443635} Committed: https://chromium.googlesource.com/chromium/src/+/1224f7bab210549bd2110b224e5697bc29feb411

Patch Set 1 #

Patch Set 2 : Rebase and cleanup #

Patch Set 3 : Minor style cleanup. #

Patch Set 4 : Remove unneeded expected result #

Total comments: 3

Patch Set 5 : Fix typos #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -70 lines) Patch
M third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-playbackrate.html View 1 2 3 4 3 chunks +61 lines, -46 lines 0 comments Download
D third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-playbackrate-expected.txt View 1 2 3 1 chunk +0 lines, -24 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Raymond Toy
PTAL
3 years, 11 months ago (2017-01-13 17:47:39 UTC) #3
Raymond Toy
Test output: This is a testharness.js-based test. PASS SNR (103.85093009191795) is greater than or equal ...
3 years, 11 months ago (2017-01-13 17:53:44 UTC) #4
hongchan
lgtm with nit https://codereview.chromium.org/2596983002/diff/60001/third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-playbackrate.html File third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-playbackrate.html (right): https://codereview.chromium.org/2596983002/diff/60001/third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-playbackrate.html#newcode94 third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-playbackrate.html:94: "Test if AudioBufferSourceNode.playbackRate can playback at ...
3 years, 11 months ago (2017-01-13 17:56:02 UTC) #5
Raymond Toy
https://codereview.chromium.org/2596983002/diff/60001/third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-playbackrate.html File third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-playbackrate.html (right): https://codereview.chromium.org/2596983002/diff/60001/third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-playbackrate.html#newcode94 third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-playbackrate.html:94: "Test if AudioBufferSourceNode.playbackRate can playback at different rates properly." ...
3 years, 11 months ago (2017-01-13 18:04:15 UTC) #6
Raymond Toy
On 2017/01/13 18:04:15, Raymond Toy wrote: > https://codereview.chromium.org/2596983002/diff/60001/third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-playbackrate.html > File > third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-playbackrate.html > (right): > ...
3 years, 11 months ago (2017-01-13 18:04:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2596983002/80001
3 years, 11 months ago (2017-01-13 18:05:15 UTC) #9
hongchan
https://codereview.chromium.org/2596983002/diff/60001/third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-playbackrate.html File third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-playbackrate.html (right): https://codereview.chromium.org/2596983002/diff/60001/third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-playbackrate.html#newcode94 third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-playbackrate.html:94: "Test if AudioBufferSourceNode.playbackRate can playback at different rates properly." ...
3 years, 11 months ago (2017-01-13 18:07:03 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 19:29:50 UTC) #13
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/1224f7bab210549bd2110b224e56...

Powered by Google App Engine
This is Rietveld 408576698