Convert audiobuffersource-playbackrate to testharness

Convert audiobuffersource-playbackrate to testharness

Manually convert test to use testharness

BUG=676394
TEST=audiobuffersource-playbackrate.html

Review-Url: https://codereview.chromium.org/2596983002
Cr-Commit-Position: refs/heads/master@{#443635}
Committed: https://chromium.googlesource.com/chromium/src/+/1224f7bab210549bd2110b224e5697bc29feb411

[Raymond Toy, 2017-01-04 19:42:32]

Description was changed from

==========
Convert AudioBufferSource tests to testharness

Manually convert test to use testharness

BUG=676394
TEST=audiobuffersource-playbackrate.html
==========

to

==========
Convert audiobuffersource-playbackrate to testharness

Manually convert test to use testharness

BUG=676394
TEST=audiobuffersource-playbackrate.html
==========

[Raymond Toy, 2017-01-13 17:47:38]

rtoy@chromium.org changed reviewers:
+ hongchan@chromium.org

[Raymond Toy, 2017-01-13 17:47:39]

PTAL

[Raymond Toy, 2017-01-13 17:53:44]

Test output:

This is a testharness.js-based test.
PASS SNR (103.85093009191795) is greater than or equal to 103.8508. 
PASS Maximum difference (in ulp units (16-bits)) (0.302734375) is less than or
equal to 0.3028. 
PASS Number of differences between results (0) is less than or equal to 0. 
PASS SNR (103.8658027256771) is greater than or equal to 103.8657. 
PASS Maximum difference (in ulp units (16-bits)) (0.302734375) is less than or
equal to 0.3029. 
PASS Number of differences between results (0) is less than or equal to 0. 
PASS SNR (103.81424611365298) is greater than or equal to 103.8141. 
PASS Maximum difference (in ulp units (16-bits)) (0.3046875) is less than or
equal to 0.3047. 
PASS Number of differences between results (0) is less than or equal to 0. 
PASS SNR (103.68193381522602) is greater than or equal to 103.6818. 
PASS Maximum difference (in ulp units (16-bits)) (0.326171875) is less than or
equal to 0.3262. 
PASS Number of differences between results (0) is less than or equal to 0. 
PASS SNR (103.1515278088242) is greater than or equal to 103.1514. 
PASS Maximum difference (in ulp units (16-bits)) (0.39453125) is less than or
equal to 0.3946. 
PASS Number of differences between results (0) is less than or equal to 0. 
Harness: the test ran to completion.

[hongchan, 2017-01-13 17:56:02]

lgtm with nit

https://codereview.chromium.org/2596983002/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-playbackrate.html
(right):

https://codereview.chromium.org/2596983002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-playbackrate.html:94:
"Test if AudioBufferSourceNode.playbackRate can playback at different rates
properly."
Let's wrap this at 80 col.

[Raymond Toy, 2017-01-13 18:04:15]

https://codereview.chromium.org/2596983002/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-playbackrate.html
(right):

https://codereview.chromium.org/2596983002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-playbackrate.html:94:
"Test if AudioBufferSourceNode.playbackRate can playback at different rates
properly."
On 2017/01/13 17:56:02, hongchan wrote:
> Let's wrap this at 80 col.

Actually this was my mistake.  This file isn't converted to new Audit, so
task.describe doesn't exist. In patch 4, I converted the string to a comment and
wrapped it.

[Raymond Toy, 2017-01-13 18:04:37]

On 2017/01/13 18:04:15, Raymond Toy wrote:
>
https://codereview.chromium.org/2596983002/diff/60001/third_party/WebKit/Layo...
> File
>
third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-playbackrate.html
> (right):
> 
>
https://codereview.chromium.org/2596983002/diff/60001/third_party/WebKit/Layo...
>
third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-playbackrate.html:94:
> "Test if AudioBufferSourceNode.playbackRate can playback at different rates
> properly."
> On 2017/01/13 17:56:02, hongchan wrote:
> > Let's wrap this at 80 col.
> 
> Actually this was my mistake.  This file isn't converted to new Audit, so
> task.describe doesn't exist. In patch 4, I converted the string to a comment
and
> wrapped it.

Patch 5, not 4.

[Raymond Toy, 2017-01-13 18:04:49]

The CQ bit was checked by rtoy@chromium.org

[commit-bot: I haz the power, 2017-01-13 18:05:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hongchan, 2017-01-13 18:07:03]

https://codereview.chromium.org/2596983002/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-playbackrate.html
(right):

https://codereview.chromium.org/2596983002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-playbackrate.html:94:
"Test if AudioBufferSourceNode.playbackRate can playback at different rates
properly."
On 2017/01/13 18:04:15, Raymond Toy wrote:
> On 2017/01/13 17:56:02, hongchan wrote:
> > Let's wrap this at 80 col.
> 
> Actually this was my mistake.  This file isn't converted to new Audit, so
> task.describe doesn't exist. In patch 4, I converted the string to a comment
and
> wrapped it.

Hmm. This is PS4. Where I can find the wrapped string?

[commit-bot: I haz the power, 2017-01-13 19:29:20]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1484330689795110,
"parent_rev": "88e2c2a04386feceaaa40129829c15432681363d", "commit_rev":
"1224f7bab210549bd2110b224e5697bc29feb411"}

[commit-bot: I haz the power, 2017-01-13 19:29:49]

Description was changed from

==========
Convert audiobuffersource-playbackrate to testharness

Manually convert test to use testharness

BUG=676394
TEST=audiobuffersource-playbackrate.html
==========

to

==========
Convert audiobuffersource-playbackrate to testharness

Manually convert test to use testharness

BUG=676394
TEST=audiobuffersource-playbackrate.html

Review-Url: https://codereview.chromium.org/2596983002
Cr-Commit-Position: refs/heads/master@{#443635}
Committed:
https://chromium.googlesource.com/chromium/src/+/1224f7bab210549bd2110b224e56...
==========

[commit-bot: I haz the power, 2017-01-13 19:29:50]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/1224f7bab210549bd2110b224e56...