discardable shared memory: Allow resetting the allocator instance.

discardable shared memory: Allow resetting the allocator instance.

Make sure the allocator can be unset when it is destroyed. This is
necessary when running tests, when each test recreates the allocator
instance. In case of views_aura_mus_unittests, this causes a number of
crashing failures, causing a lot of tests to be re-run separately.
Without this fix, the test step takes ~40 seconds to complete. With this
fix, it takes ~7 seconds.

BUG=none

Committed: https://crrev.com/b61111db19d6b9f012c470d01a59bcb4e7c882db
Cr-Commit-Position: refs/heads/master@{#440270}

[sadrul, 2016-12-21 17:39:17]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 17:39:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2016-12-21 17:41:48]

sadrul@chromium.org changed reviewers:
+ reveman@chromium.org

[reveman, 2016-12-21 17:51:26]

lgtm

[sadrul, 2016-12-21 17:52:41]

sadrul@chromium.org changed reviewers:
+ thakis@chromium.org

[sadrul, 2016-12-21 17:52:41]

+thakis@ for base/

[Nico, 2016-12-21 18:00:27]

what's this for? test?

[sadrul, 2016-12-21 18:01:46]

On 2016/12/21 18:00:27, Nico (swamped sorry) wrote:
> what's this for? test?

It is, yes. (we recreate the allocator for each test)

[Nico, 2016-12-21 18:03:52]

On 2016/12/21 18:01:46, sadrul wrote:
> On 2016/12/21 18:00:27, Nico (swamped sorry) wrote:
> > what's this for? test?
> 
> It is, yes. (we recreate the allocator for each test)

are any tests failing because of that? please make cl description longer so
people who aren't familiar with things (me) can understand what the motivation
is.

[sadrul, 2016-12-21 18:05:17]

Description was changed from

==========
discardable shared memory: Allow resetting the allocator instance.

Make sure the allocator can be unset when it is destroyed.

BUG=none
==========

to

==========
discardable shared memory: Allow resetting the allocator instance.

Make sure the allocator can be unset when it is destroyed. This is
necessary when running tests, when each test recreates the allocator
instance.

BUG=none
==========

[sadrul, 2016-12-21 18:06:44]

On 2016/12/21 18:03:52, Nico (swamped sorry) wrote:
> On 2016/12/21 18:01:46, sadrul wrote:
> > On 2016/12/21 18:00:27, Nico (swamped sorry) wrote:
> > > what's this for? test?
> > 
> > It is, yes. (we recreate the allocator for each test)
> 
> are any tests failing because of that? please make cl description longer so
> people who aren't familiar with things (me) can understand what the motivation
> is.

Update the CL description (sorry!). No tests fail yet, since there is only one
test right now. https://codereview.chromium.org/2596723002/ adds a new CL that
requires this fix. (I deliberately split out this CL into a separate one, but
can merge back to that CL if you think that'd make it easier to follow)

[sadrul, 2016-12-21 18:15:07]

Description was changed from

==========
discardable shared memory: Allow resetting the allocator instance.

Make sure the allocator can be unset when it is destroyed. This is
necessary when running tests, when each test recreates the allocator
instance.

BUG=none
==========

to

==========
discardable shared memory: Allow resetting the allocator instance.

Make sure the allocator can be unset when it is destroyed. This is
necessary when running tests, when each test recreates the allocator
instance (e.g. in views_aura_mus_unittests).

BUG=none
==========

[sadrul, 2016-12-21 18:24:54]

Description was changed from

==========
discardable shared memory: Allow resetting the allocator instance.

Make sure the allocator can be unset when it is destroyed. This is
necessary when running tests, when each test recreates the allocator
instance (e.g. in views_aura_mus_unittests).

BUG=none
==========

to

==========
discardable shared memory: Allow resetting the allocator instance.

Make sure the allocator can be unset when it is destroyed. This is
necessary when running tests, when each test recreates the allocator
instance. In case of views_aura_mus_unittests, this causes a number of
crashing failures, causing a lot of tests to be re-run separately.
Without this fix, the test step takes ~40 seconds to complete. With this
fix, it takes ~7 seconds.

BUG=none
==========

[sadrul, 2016-12-21 18:28:42]

On 2016/12/21 18:06:44, sadrul wrote:
> On 2016/12/21 18:03:52, Nico (swamped sorry) wrote:
> > On 2016/12/21 18:01:46, sadrul wrote:
> > > On 2016/12/21 18:00:27, Nico (swamped sorry) wrote:
> > > > what's this for? test?
> > > 
> > > It is, yes. (we recreate the allocator for each test)
> > 
> > are any tests failing because of that? please make cl description longer so
> > people who aren't familiar with things (me) can understand what the
motivation
> > is.
> 
> Update the CL description (sorry!). No tests fail yet,

Looked a bit more closely: turns out, we do have failing tests, but we don't see
them because the tests are retried individually. Updated the CL description.
Summary: brings down views_aura_mus_unittests runtime from ~35/40 seconds to
~5/7 seconds.

Some links without this fix:
https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium...
https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium...
https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium...
https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium...

With this fix:
https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium...

> since there is only one
> test right now. https://codereview.chromium.org/2596723002/ adds a new CL that
> requires this fix. (I deliberately split out this CL into a separate one, but
> can merge back to that CL if you think that'd make it easier to follow)

[commit-bot: I haz the power, 2016-12-21 18:54:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 18:54:13]

Dry run: This issue passed the CQ dry run.

[Nico, 2016-12-21 21:17:23]

lgtm, thanks!

[sadrul, 2016-12-21 23:52:49]

The CQ bit was checked by sadrul@chromium.org

[commit-bot: I haz the power, 2016-12-21 23:53:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 00:00:48]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1482364369733520, "parent_rev":
"d26ed5c2eb8bdb21f411880545bf3a8f8c168059", "commit_rev":
"0e272c8be44956c6bade2c109dbf55c4d3c1b755"}

[commit-bot: I haz the power, 2016-12-22 00:01:17]

Description was changed from

==========
discardable shared memory: Allow resetting the allocator instance.

Make sure the allocator can be unset when it is destroyed. This is
necessary when running tests, when each test recreates the allocator
instance. In case of views_aura_mus_unittests, this causes a number of
crashing failures, causing a lot of tests to be re-run separately.
Without this fix, the test step takes ~40 seconds to complete. With this
fix, it takes ~7 seconds.

BUG=none
==========

to

==========
discardable shared memory: Allow resetting the allocator instance.

Make sure the allocator can be unset when it is destroyed. This is
necessary when running tests, when each test recreates the allocator
instance. In case of views_aura_mus_unittests, this causes a number of
crashing failures, causing a lot of tests to be re-run separately.
Without this fix, the test step takes ~40 seconds to complete. With this
fix, it takes ~7 seconds.

BUG=none

Review-Url: https://codereview.chromium.org/2596903002
==========

[commit-bot: I haz the power, 2016-12-22 00:01:17]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-22 00:04:20]

Description was changed from

==========
discardable shared memory: Allow resetting the allocator instance.

Make sure the allocator can be unset when it is destroyed. This is
necessary when running tests, when each test recreates the allocator
instance. In case of views_aura_mus_unittests, this causes a number of
crashing failures, causing a lot of tests to be re-run separately.
Without this fix, the test step takes ~40 seconds to complete. With this
fix, it takes ~7 seconds.

BUG=none

Review-Url: https://codereview.chromium.org/2596903002
==========

to

==========
discardable shared memory: Allow resetting the allocator instance.

Make sure the allocator can be unset when it is destroyed. This is
necessary when running tests, when each test recreates the allocator
instance. In case of views_aura_mus_unittests, this causes a number of
crashing failures, causing a lot of tests to be re-run separately.
Without this fix, the test step takes ~40 seconds to complete. With this
fix, it takes ~7 seconds.

BUG=none

Committed: https://crrev.com/b61111db19d6b9f012c470d01a59bcb4e7c882db
Cr-Commit-Position: refs/heads/master@{#440270}
==========

[commit-bot: I haz the power, 2016-12-22 00:04:21]

Patchset 1 (id:??) landed as
https://crrev.com/b61111db19d6b9f012c470d01a59bcb4e7c882db
Cr-Commit-Position: refs/heads/master@{#440270}