Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 2596893002: predictors: Wait for the cache cleaning synchronously. (Closed)

Created:
4 years ago by alexilin
Modified:
4 years ago
Reviewers:
Benoit L
CC:
chromium-reviews, ahemery
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

predictors: Wait for the cache cleaning synchronously. chrome::ClearCache() is asynchronous so there was possibility that cache is cleared after prefetching causing flakiness. This problem was almost hidden by that fact that the last navigation (after prefetching) also caused prefetching. So the probability that cache is cleared after the second prefetching was even less. This CL also changes command line flag to disable the second prefetching because it only tangles the tests. BUG=650253 Committed: https://crrev.com/f15203e94ad5245c9ab50fbc0e1385ef403d0903 Cr-Commit-Position: refs/heads/master@{#440379}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -3 lines) Patch
M chrome/browser/predictors/resource_prefetch_predictor_browsertest.cc View 4 chunks +31 lines, -3 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 11 (6 generated)
alexilin
I created one more flaky test (yay!) This is the fix...
4 years ago (2016-12-21 17:28:34 UTC) #3
Benoit L
lgtm, thanks.
4 years ago (2016-12-22 10:18:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2596893002/1
4 years ago (2016-12-22 10:33:08 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-22 11:10:06 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-22 11:12:37 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f15203e94ad5245c9ab50fbc0e1385ef403d0903
Cr-Commit-Position: refs/heads/master@{#440379}

Powered by Google App Engine
This is Rietveld 408576698