Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 2596843002: [turbofan] Optimize store to typed arrays only if the value is plain primitive. (Closed)

Created:
4 years ago by Jarin
Modified:
3 years, 12 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Optimize store to typed arrays only if the value is plain primitive. BUG=v8:5756 Review-Url: https://codereview.chromium.org/2596843002 Cr-Commit-Position: refs/heads/master@{#41942} Committed: https://chromium.googlesource.com/v8/v8/+/e92118bbc25c39b3213a3f4dcbf35e825eaf0b8a

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix unit test #

Patch Set 3 : Remove dead variable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -13 lines) Patch
M src/compiler/js-typed-lowering.cc View 1 2 3 chunks +5 lines, -7 lines 0 comments Download
A test/mjsunit/compiler/regress-v8-5756.js View 1 chunk +31 lines, -0 lines 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 1 3 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 21 (15 generated)
Benedikt Meurer
I'd love to get rid of the whole code in JSTypedLowering, but meanwhile this is ...
4 years ago (2016-12-21 18:33:39 UTC) #6
Benedikt Meurer
https://codereview.chromium.org/2596843002/diff/1/test/mjsunit/compiler/regress-v8-5756.js File test/mjsunit/compiler/regress-v8-5756.js (right): https://codereview.chromium.org/2596843002/diff/1/test/mjsunit/compiler/regress-v8-5756.js#newcode19 test/mjsunit/compiler/regress-v8-5756.js:19: t[2] = z; // since we are assigning to ...
4 years ago (2016-12-22 04:50:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2596843002/20001
3 years, 12 months ago (2016-12-23 13:04:57 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/builds/10247)
3 years, 12 months ago (2016-12-23 13:09:18 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2596843002/40001
3 years, 12 months ago (2016-12-23 14:03:26 UTC) #18
commit-bot: I haz the power
3 years, 12 months ago (2016-12-23 14:29:06 UTC) #21
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/e92118bbc25c39b3213a3f4dcbf35e825ea...

Powered by Google App Engine
This is Rietveld 408576698