Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 2596833002: Add unit test for color managed ImageBitamp::create(StaticBitmapImage) (Closed)

Created:
3 years, 12 months ago by zakerinasab
Modified:
3 years, 12 months ago
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add unit test for color managed ImageBitamp::create(StaticBitmapImage) This CL is the follow up for CL 2522693002, part of color management implementation for ImageBitmap as described in proposal: (github.com/junov/CanvasColorSpace/blob/master/CanvasColorSpaceProposal.md) BUG=665919 Committed: https://crrev.com/31b964e99561272c4a6ffa53a12ef6caa83412b6 Cr-Commit-Position: refs/heads/master@{#440191}

Patch Set 1 #

Patch Set 2 : Minor corrections #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -4 lines) Patch
M third_party/WebKit/Source/core/frame/ImageBitmapTest.cpp View 1 2 chunks +95 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
zakerinasab1
New CL for ImageBitmap color correction. PTAL.
3 years, 12 months ago (2016-12-21 14:59:06 UTC) #4
Justin Novosad
lgtm
3 years, 12 months ago (2016-12-21 17:49:04 UTC) #6
dcheng
lgtm
3 years, 12 months ago (2016-12-21 18:38:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2596833002/40001
3 years, 12 months ago (2016-12-21 18:52:20 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:40001)
3 years, 12 months ago (2016-12-21 20:01:30 UTC) #12
commit-bot: I haz the power
3 years, 12 months ago (2016-12-21 20:03:45 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/31b964e99561272c4a6ffa53a12ef6caa83412b6
Cr-Commit-Position: refs/heads/master@{#440191}

Powered by Google App Engine
This is Rietveld 408576698