Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 2596803002: [ast] Delete unused variables. (Closed)

Created:
4 years ago by Franzi
Modified:
3 years, 11 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ast] Delete unused variables. BUG= Review-Url: https://codereview.chromium.org/2596803002 Cr-Commit-Position: refs/heads/master@{#42131} Committed: https://chromium.googlesource.com/v8/v8/+/4805790c60f404d868a80f78675747a1e1c8cfdf

Patch Set 1 #

Patch Set 2 : [ast] Delete unused variable. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -15 lines) Patch
M src/ast/ast.h View 1 6 chunks +0 lines, -15 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
Franzi
Hi Toon, Can these unused variables be deleted or did we mean to use them ...
4 years ago (2016-12-21 12:41:32 UTC) #8
Toon Verwaest
lgtm
3 years, 11 months ago (2017-01-09 09:12:07 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2596803002/20001
3 years, 11 months ago (2017-01-09 09:24:31 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-09 09:51:35 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/4805790c60f404d868a80f78675747a1e1c...

Powered by Google App Engine
This is Rietveld 408576698