On macOS, avoid forcible activation during Show.

chrome/browser/ui/views/frame/browser_view.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/frame/browser_view.h"
 
 #include <stdint.h>
 
 #include <algorithm>
 #include <memory>
@@ skipping 583 matching lines @@
 
 void BrowserView::Show() {
 #if !defined(OS_WIN) && !defined(USE_ASH)
   // The Browser associated with this browser window must become the active
   // browser at the time |Show()| is called. This is the natural behavior under
   // Windows and Ash, but other platforms will not trigger
   // OnWidgetActivationChanged() until we return to the runloop. Therefore any
   // calls to Browser::GetLastActive() will return the wrong result if we do not
   // explicitly set it here.
   // A similar block also appears in BrowserWindowCocoa::Show().
   BrowserList::SetLastActive(browser());

[Peter Kasting, 2016/12/22 00:38:42]

Is it inconsistent that we SetLastActive() a window we're not going activate? 
Do we still want to do this in the "show in background" case?

[tapted, 2017/01/03 03:27:06]

Please respond to comments on the code itself using the `Reply` link - I'm
copying your response below

On 2016/12/22 00:38:42, Peter Kasting OOO Dec 25-Jan 3 wrote:
That's incorrect. ShowInactive "raises" the window but does not transfer focus
("key state" on Mac). SetLastActive should only be called when key status is
being transferred.

 #endif
 
   // If the window is already visible, just activate it.
   if (frame_->IsVisible()) {
+#if !defined(OS_MACOSX)

[Peter Kasting, 2016/12/22 00:38:42]

Nit: Remove "!" and reverse arms, so "else" doesn't read like a mental
double-negative.

     frame_->Activate();
+#else
+    // When opening a URL from other application, macOS will activate browser

[Peter Kasting, 2016/12/22 00:38:42]

Nit: other -> another, browser -> the browser

+    // window in case when "Open" action is used, but won't do it in case when

[Peter Kasting, 2016/12/22 00:38:42]

Nit: in case -> in the case (2x)

+    // "Open Behind" is requested. Let's assume macOS handles the activation
+    // for us, just put the window above other browser windows.

[Peter Kasting, 2016/12/22 00:38:42]

Nit: , -> ;

+    frame_->ShowInactive();
+#endif
     return;
   }
 
   // Showing the window doesn't make the browser window active right away.
   // This can cause SetFocusToLocationBar() to skip setting focus to the
   // location bar. To avoid this we explicilty let SetFocusToLocationBar()
   // know that it's ok to steal focus.
   force_location_bar_focus_ = true;
 
   // Setting the focus doesn't work when the window is invisible, so any focus
@@ skipping 1965 matching lines @@
 }
 
 extensions::ActiveTabPermissionGranter*
 BrowserView::GetActiveTabPermissionGranter() {
   content::WebContents* web_contents = GetActiveWebContents();
   if (!web_contents)
     return nullptr;
   return extensions::TabHelper::FromWebContents(web_contents)
       ->active_tab_permission_granter();
 }