Replace WM shadow types (on/off) and styles (small/inactive/active)

ash/common/wm/overview/window_grid.cc

Index: ash/common/wm/overview/window_grid.cc
diff --git a/ash/common/wm/overview/window_grid.cc b/ash/common/wm/overview/window_grid.cc
index 428e046dbc5cfef92fb4fc51a030df6877fc98b9..bccb3fe41362731505c483c1614d8b5d216bb4a6 100644
--- a/ash/common/wm/overview/window_grid.cc
+++ b/ash/common/wm/overview/window_grid.cc
@@ -44,6 +44,7 @@
 #include "ui/views/view.h"
 #include "ui/views/widget/widget.h"
 #include "ui/wm/core/shadow.h"
+#include "ui/wm/core/shadow_types.h"
 #include "ui/wm/core/window_animations.h"
 
 namespace ash {
@@ -675,7 +676,7 @@ void WindowGrid::InitSelectionWidget(WindowSelector::Direction direction) {
   widget_window->SetName("OverviewModeSelector");
 
   selector_shadow_.reset(new ::wm::Shadow());
-  selector_shadow_->Init(::wm::Shadow::STYLE_ACTIVE);
+  selector_shadow_->Init(::wm::ShadowElevation::BIG);

[sky, 2017/01/03 22:35:38]

Inside ShadowController you define kActiveNormalShadowElevation, should this
code use kActiveNormalShadowElevation rather than explicitly BIG?

[Evan Stade, 2017/01/04 00:20:45]

IMO it's better that it doesn't, because the selector is not the same thing as
the "active" window. (If it were, you wouldn't have this code here.) So now if
we decide to change the size of large shadows across the board, we just change
the enum value to something else, but if we just want to adjust how big shadows
are for the active window, we can do that without affecting unrelated shadows.

   selector_shadow_->layer()->SetVisible(true);
   selection_widget_->GetLayer()->SetMasksToBounds(false);
   selection_widget_->GetLayer()->Add(selector_shadow_->layer());