Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: ui/wm/core/shadow_types.h

Issue 2596743002: Replace WM shadow types (on/off) and styles (small/inactive/active) (Closed)
Patch Set: one more mechanical change Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/wm/core/shadow_controller_unittest.cc ('k') | ui/wm/core/shadow_types.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/wm/core/shadow_types.h
diff --git a/ui/wm/core/shadow_types.h b/ui/wm/core/shadow_types.h
index 1198a43b16c72c84abd56a86d30fdf6e90e5d0b1..8de25e83024734f2fbe7fcbf6528bff8ef9ec192 100644
--- a/ui/wm/core/shadow_types.h
+++ b/ui/wm/core/shadow_types.h
@@ -15,19 +15,22 @@ class Window;
namespace wm {
// Different types of drop shadows that can be drawn under a window by the
-// shell. Used as a value for the kShadowTypeKey property.
-enum ShadowType {
- // Starts at 0 due to the cast in GetShadowType().
- SHADOW_TYPE_NONE = 0,
- SHADOW_TYPE_RECTANGULAR,
+// shell. Used as a value for the kShadowTypeKey property. The integer value of
+// each entry is directly used for determining the size of the shadow.
+enum class ShadowElevation {
+ NONE = 0,
+ SMALL = 6,
+ MEDIUM = 8,
+ LARGE = 24,
};
-WM_EXPORT void SetShadowType(aura::Window* window, ShadowType shadow_type);
-WM_EXPORT ShadowType GetShadowType(aura::Window* window);
+WM_EXPORT void SetShadowElevation(aura::Window* window,
+ ShadowElevation shadow_type);
+WM_EXPORT ShadowElevation GetShadowElevation(aura::Window* window);
// A property key describing the drop shadow that should be displayed under the
// window. If unset, no shadow is displayed.
-extern const aura::WindowProperty<ShadowType>* const kShadowTypeKey;
+extern const aura::WindowProperty<ShadowElevation>* const kShadowElevationKey;
} // namespace wm
« no previous file with comments | « ui/wm/core/shadow_controller_unittest.cc ('k') | ui/wm/core/shadow_types.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698