Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 2596673002: [test] Avoid stack space exhaustion in test by passing --no-lazy (Closed)

Created:
4 years ago by adamk
Modified:
4 years ago
Reviewers:
marja
CC:
v8-reviews_googlegroups.com, Michael Hablich, Leszek Swirski
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Avoid stack space exhaustion in test by passing --no-lazy The test depends on tricky stack space requirements, so it stopped working in some configurations win FLAG_min_preparse_length was removed in commit 4a5b7e32c4f687bd481fc6d58adf7c2c695d2466. As a workaround, pass --no-lazy until the test can be refined to work on all configurations. BUG=v8:5729 TBR=marja@chromium.org Review-Url: https://codereview.chromium.org/2596673002 Cr-Commit-Position: refs/heads/master@{#41878} Committed: https://chromium.googlesource.com/v8/v8/+/b0c05f4ab351a0a595c551489e08fec83be75d11

Patch Set 1 #

Patch Set 2 : Proper diff #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M test/mjsunit/big-array-literal.js View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
adamk
4 years ago (2016-12-20 23:43:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2596673002/20001
4 years ago (2016-12-20 23:43:29 UTC) #3
commit-bot: I haz the power
4 years ago (2016-12-21 00:08:53 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/b0c05f4ab351a0a595c551489e08fec83be...

Powered by Google App Engine
This is Rietveld 408576698