Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2596653003: [ios] Removed CookieStoreIOS::SetCookiePolicy. (Closed)

Created:
4 years ago by Eugene But (OOO till 7-30)
Modified:
4 years ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, pkl (ping after 24h if needed), sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Removed CookieStoreIOS::SetCookiePolicy. After switching to WKWebView this API is not needed anymore. New cookie policy takes effect only after app restart which is not useful. BUG=676144 Committed: https://crrev.com/f26cdbcbddb5e78a4791e8637653047caafd3156 Cr-Commit-Position: refs/heads/master@{#440108}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -272 lines) Patch
M ios/chrome/app/app_delegate.mm View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/app/main_controller.mm View 3 chunks +0 lines, -40 lines 0 comments Download
M ios/chrome/app/steps/launch_to_foreground.h View 1 chunk +0 lines, -8 lines 0 comments Download
M ios/chrome/app/steps/launch_to_foreground.mm View 2 chunks +0 lines, -52 lines 0 comments Download
M ios/net/cookies/cookie_store_ios.h View 3 chunks +0 lines, -9 lines 0 comments Download
M ios/net/cookies/cookie_store_ios.mm View 4 chunks +0 lines, -57 lines 0 comments Download
M ios/net/cookies/cookie_store_ios_unittest.mm View 6 chunks +1 line, -93 lines 0 comments Download
M ios/web/public/web_capabilities.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ios/web/public/web_capabilities.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M ios/web/shell/view_controller.mm View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Eugene But (OOO till 7-30)
4 years ago (2016-12-20 23:39:04 UTC) #2
marq (ping after 24h)
LGTM, and thanks for getting the new architecture files as well.
4 years ago (2016-12-21 06:24:20 UTC) #7
Eugene But (OOO till 7-30)
Thanks!
4 years ago (2016-12-21 15:21:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2596653003/1
4 years ago (2016-12-21 15:21:52 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-21 15:26:42 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-21 15:28:30 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f26cdbcbddb5e78a4791e8637653047caafd3156
Cr-Commit-Position: refs/heads/master@{#440108}

Powered by Google App Engine
This is Rietveld 408576698