Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 2596653002: Remove support for Ubuntu/Precise sysroot (Closed)

Created:
4 years ago by Sam Clegg
Modified:
3 years, 8 months ago
CC:
chromium-reviews, Lei Zhang, Nico
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove support for Ubuntu/Precise sysroot BUG=564904 Review-Url: https://codereview.chromium.org/2596653002 Cr-Commit-Position: refs/heads/master@{#462884} Committed: https://chromium.googlesource.com/chromium/src/+/bc51e877f354bd818135a324c3a16d4a1f8abf30

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -412 lines) Patch
M build/experimental/install-build-deps.py View 1 2 chunks +1 line, -4 lines 0 comments Download
M build/install-build-deps-android.sh View 1 1 chunk +1 line, -5 lines 0 comments Download
M build/linux/sysroot_scripts/install-sysroot.py View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
D build/linux/sysroot_scripts/packagelist.precise.amd64 View 1 1 chunk +0 lines, -179 lines 0 comments Download
D build/linux/sysroot_scripts/sysroot-creator-precise.sh View 1 1 chunk +0 lines, -212 lines 0 comments Download
M build/linux/sysroot_scripts/sysroots.json View 1 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
Sam Clegg
3 years, 8 months ago (2017-04-07 00:20:34 UTC) #6
Tom Anderson
LGTM Can you also remove these https://cs.chromium.org/chromium/src/tools/checklicenses/checklicenses.py?rcl=99cc887ad000b29513c3d2613efa46f26199e504&l=660 https://cs.chromium.org/chromium/src/tools/copyright_scanner/copyright_scanner.py?rcl=99cc887ad000b29513c3d2613efa46f26199e504&l=80
3 years, 8 months ago (2017-04-07 00:24:23 UTC) #7
Sam Clegg
On 2017/04/07 00:24:23, Thomas Anderson wrote: > LGTM > > Can you also remove these ...
3 years, 8 months ago (2017-04-07 00:27:27 UTC) #8
Tom (Use chromium acct)
On 2017/04/07 00:27:27, Sam Clegg wrote: > On 2017/04/07 00:24:23, Thomas Anderson wrote: > > ...
3 years, 8 months ago (2017-04-07 00:29:46 UTC) #9
Dirk Pranke
On 2017/04/07 00:29:46, Tom Anderson wrote: > On 2017/04/07 00:27:27, Sam Clegg wrote: > > ...
3 years, 8 months ago (2017-04-07 00:47:50 UTC) #12
Dirk Pranke
lgtm
3 years, 8 months ago (2017-04-07 00:48:24 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2596653002/40001
3 years, 8 months ago (2017-04-07 16:15:08 UTC) #15
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 16:21:23 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/bc51e877f354bd818135a324c3a1...

Powered by Google App Engine
This is Rietveld 408576698