Fix captive portal window on sign-in screen

Fix captive portal window on sign-in screen

The captive portal window was being blocked by the GAIA auth extensions's
background script because the script could not tell it from the GAIA login
frame. This CL ensures that the login UI has a unique tab ID, making it
distinguishable from the captive portal window.

BUG=367713
TEST=Manual; updated tests forthcoming in bug 367731

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266788

[bartfab (slow), 2014-04-28 14:09:45]

Hi Hui and Xiyuan,

Could you check whether this looks like the right fix? I took the idea from your
comment at http://crbug.com/363994#c14. It makes sense to me and it works. But
in bug 363994, Xiyuan had called this kind of addition a workaround, so I want
to check that it is a valid fix, not just a hacky workaround, before checking
anything in.

Hi Yuri,

Could you please do an owner review?

[xiyuan, 2014-04-28 16:07:10]

I think that's right thing to do before we have webview.

LGTM.

[guohui, 2014-04-28 16:29:24]

https://codereview.chromium.org/259663006/diff/1/chrome/browser/chromeos/logi...
File chrome/browser/chromeos/login/webui_login_view.cc (right):

https://codereview.chromium.org/259663006/diff/1/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/webui_login_view.cc:179:
SessionTabHelper::CreateForWebContents(web_contents);
could you please move this to inline_login_ui.cc so that it applies to all
inline signin flows?

https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...

[xiyuan, 2014-04-28 16:30:22]

https://codereview.chromium.org/259663006/diff/1/chrome/browser/chromeos/logi...
File chrome/browser/chromeos/login/webui_login_view.cc (right):

https://codereview.chromium.org/259663006/diff/1/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/webui_login_view.cc:179:
SessionTabHelper::CreateForWebContents(web_contents);
On 2014/04/28 16:29:24, guohui wrote:
> could you please move this to inline_login_ui.cc so that it applies to all
> inline signin flows?
> 
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...

Cros login screen does not use InlinLoginUI. This is needed here too.

[guohui, 2014-04-28 16:40:24]

lgtm

https://codereview.chromium.org/259663006/diff/1/chrome/browser/chromeos/logi...
File chrome/browser/chromeos/login/webui_login_view.cc (right):

https://codereview.chromium.org/259663006/diff/1/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/webui_login_view.cc:179:
SessionTabHelper::CreateForWebContents(web_contents);
On 2014/04/28 16:30:22, xiyuan wrote:
> On 2014/04/28 16:29:24, guohui wrote:
> > could you please move this to inline_login_ui.cc so that it applies to all
> > inline signin flows?
> > 
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...
> 
> Cros login screen does not use InlinLoginUI. This is needed here too.

as discussed with xiyuan over chat, i ll handle the change in
inline_login_ui.cc, so please ignore my comment above.

Thanks!

[Nikita (slow), 2014-04-28 16:57:09]

lgtm

[bartfab (slow), 2014-04-28 17:02:12]

The CQ bit was checked by bartfab@chromium.org

[commit-bot: I haz the power, 2014-04-28 17:02:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bartfab@chromium.org/259663006/1

[commit-bot: I haz the power, 2014-04-28 17:51:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-28 17:51:17]

Try jobs failed on following builders:
  tryserver.chromium on chromium_presubmit

[bartfab (slow), 2014-04-29 07:59:07]

The CQ bit was checked by bartfab@chromium.org

[commit-bot: I haz the power, 2014-04-29 08:00:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bartfab@chromium.org/259663006/1

[commit-bot: I haz the power, 2014-04-29 08:53:49]

Change committed as 266788