Fix captive portal window on sign-in screen

chrome/browser/chromeos/login/webui_login_view.cc

Index: chrome/browser/chromeos/login/webui_login_view.cc
diff --git a/chrome/browser/chromeos/login/webui_login_view.cc b/chrome/browser/chromeos/login/webui_login_view.cc
index f48a3a7966dbf01a32f4359fcb624059b63fa6ac..79d62f2e9dba232918ca4e53b0649f52a93d3d8a 100644
--- a/chrome/browser/chromeos/login/webui_login_view.cc
+++ b/chrome/browser/chromeos/login/webui_login_view.cc
@@ -22,6 +22,7 @@
 #include "chrome/browser/media/media_stream_infobar_delegate.h"
 #include "chrome/browser/password_manager/chrome_password_manager_client.h"
 #include "chrome/browser/renderer_preferences_util.h"
+#include "chrome/browser/sessions/session_tab_helper.h"
 #include "chrome/browser/ui/autofill/tab_autofill_manager_delegate.h"
 #include "chrome/browser/ui/webui/chromeos/login/oobe_ui.h"
 #include "chrome/common/render_messages.h"
@@ -172,6 +173,11 @@ void WebUILoginView::Init() {
 
   WebContents* web_contents = webui_login_->GetWebContents();
 
+  // Ensure that the login UI has a tab ID, which will allow the GAIA auth
+  // extension's background script to tell it apart from a captive portal window
+  // that may be opened on top of this UI.
+  SessionTabHelper::CreateForWebContents(web_contents);

[guohui, 2014/04/28 16:29:24]

could you please move this to inline_login_ui.cc so that it applies to all
inline signin flows?

https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...

[xiyuan, 2014/04/28 16:30:22]

Cros login screen does not use InlinLoginUI. This is needed here too.

[guohui, 2014/04/28 16:40:24]

as discussed with xiyuan over chat, i ll handle the change in
inline_login_ui.cc, so please ignore my comment above.

Thanks!

+
   // Create the password manager that is needed for the proxy.
   ChromePasswordManagerClient::CreateForWebContentsWithAutofillManagerDelegate(
       web_contents,