Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 2596593003: Fix use-after-free in TextureLayerImplTest.ResourceNotFreedOnGpuRasterToggle. (Closed)

Created:
4 years ago by krasin1
Modified:
4 years ago
Reviewers:
ccameron
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix use-after-free in TextureLayerImplTest.ResourceNotFreedOnGpuRasterToggle. The callback uses a local variable 'released', but 'released' had a more narrow scope than the owner of the callback (and it's called from the destructor, when 'released' is already out of scope) BUG=649897 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Committed: https://crrev.com/360dee282db84d1e63414c9e8d471a7465a8441d Cr-Commit-Position: refs/heads/master@{#439888}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M cc/layers/texture_layer_impl_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
krasin1
4 years ago (2016-12-20 21:45:52 UTC) #3
ccameron
lgtm
4 years ago (2016-12-20 21:47:07 UTC) #6
krasin1
On 2016/12/20 21:47:07, ccameron wrote: > lgtm Thank you for the instant review!
4 years ago (2016-12-20 21:59:05 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2596593003/1
4 years ago (2016-12-20 21:59:17 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-20 22:07:39 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-20 22:11:18 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/360dee282db84d1e63414c9e8d471a7465a8441d
Cr-Commit-Position: refs/heads/master@{#439888}

Powered by Google App Engine
This is Rietveld 408576698