Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2596583002: [Schema Compiler] Separate out SchemaLoader and namespace resolving (Closed)

Created:
4 years ago by Devlin
Modified:
4 years ago
Reviewers:
lazyboy
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Schema Compiler] Separate out SchemaLoader and namespace resolving The SchemaLoader name implies that the object is used for loading schemas, but for some reason also has logic to resolve a type and namespace. Move this into a separate NamespaceResolver file to make it easier to reuse SchemaLoader. BUG=None Committed: https://crrev.com/227d70cd9810003079c3a799b51872d91b0d0a63 Cr-Commit-Position: refs/heads/master@{#440201}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -119 lines) Patch
M tools/json_schema_compiler/compiler.py View 1 3 chunks +6 lines, -7 lines 0 comments Download
M tools/json_schema_compiler/cpp_type_generator.py View 4 chunks +5 lines, -5 lines 0 comments Download
A + tools/json_schema_compiler/namespace_resolver.py View 1 5 chunks +17 lines, -34 lines 0 comments Download
M tools/json_schema_compiler/preview.py View 2 chunks +7 lines, -7 lines 0 comments Download
M tools/json_schema_compiler/schema_loader.py View 2 chunks +4 lines, -66 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Devlin
4 years ago (2016-12-20 22:30:04 UTC) #5
lazyboy
lgtm
4 years ago (2016-12-21 19:54:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2596583002/20001
4 years ago (2016-12-21 20:17:57 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-21 20:24:52 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-21 20:26:47 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/227d70cd9810003079c3a799b51872d91b0d0a63
Cr-Commit-Position: refs/heads/master@{#440201}

Powered by Google App Engine
This is Rietveld 408576698