[promises] Move Promise.prototype.catch to TF

[promises] Move Promise.prototype.catch to TF

This patch also refactors most of PromiseThen into InternalPromiseThen to 
be reused with PromiseCatch and also changes InternalResolvePromise to 
return and not branch.

BUG=v8:5343
Review-Url: https://codereview.chromium.org/2596553002
Cr-Commit-Position: refs/heads/master@{#41902}
Committed: https://chromium.googlesource.com/v8/v8/+/2041c504025d706041e50e52d9e8c7221667492d

[gsathya, 2016-12-20 19:34:45]

The CQ bit was checked by gsathya@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-20 19:34:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 19:36:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 19:36:25]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)

[gsathya, 2016-12-20 19:37:41]

Description was changed from

==========
[promises] Move Promise.prototype.catch to TF

BUG=v8:5343
==========

to

==========
[promises] Move Promise.prototype.catch to TF

This patch also refactors most of PromiseThen into InternalPromiseThen to 
be reused with PromiseCatch and also changes InternalResolvePromise to 
return and not branch.

BUG=v8:5343
==========

[gsathya, 2016-12-20 19:38:34]

The CQ bit was checked by gsathya@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-20 19:38:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gsathya, 2016-12-20 19:46:07]

gsathya@chromium.org changed reviewers:
+ ishell@chromium.org, jgruber@chromium.org

[commit-bot: I haz the power, 2016-12-20 19:59:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 19:59:28]

Dry run: Try jobs failed on following builders:
  v8_win64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/19810)
  v8_win64_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng_triggered/b...)

[gsathya, 2016-12-20 20:26:45]

The CQ bit was checked by gsathya@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-20 20:26:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 20:40:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 20:40:44]

Dry run: Try jobs failed on following builders:
  v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_asan_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng_trig...)

[gsathya, 2016-12-20 20:43:31]

The CQ bit was checked by gsathya@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-20 20:43:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 21:10:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 21:10:48]

Dry run: This issue passed the CQ dry run.

[jgruber, 2016-12-21 06:55:29]

lgtm with nits

https://codereview.chromium.org/2596553002/diff/60001/src/builtins/builtins-p...
File src/builtins/builtins-promise.cc (right):

https://codereview.chromium.org/2596553002/diff/60001/src/builtins/builtins-p...
src/builtins/builtins-promise.cc:595: return;
Nit: Please remove this.

https://codereview.chromium.org/2596553002/diff/60001/src/builtins/builtins-p...
src/builtins/builtins-promise.cc:1004: TF_BUILTIN(PromiseCatch,
PromiseBuiltinsAssembler) {
Could you add a comment linking to the spec (same for other functions)?

// ES#sec-promise-objects

[gsathya, 2016-12-21 17:27:38]

The CQ bit was checked by gsathya@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 17:27:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gsathya, 2016-12-21 17:27:55]

Thanks!

https://codereview.chromium.org/2596553002/diff/60001/src/builtins/builtins-p...
File src/builtins/builtins-promise.cc (right):

https://codereview.chromium.org/2596553002/diff/60001/src/builtins/builtins-p...
src/builtins/builtins-promise.cc:595: return;
On 2016/12/21 06:55:29, jgruber wrote:
> Nit: Please remove this.

Done.

https://codereview.chromium.org/2596553002/diff/60001/src/builtins/builtins-p...
src/builtins/builtins-promise.cc:1004: TF_BUILTIN(PromiseCatch,
PromiseBuiltinsAssembler) {
On 2016/12/21 06:55:29, jgruber wrote:
> Could you add a comment linking to the spec (same for other functions)?
> 
> // ES#sec-promise-objects

Done.

[commit-bot: I haz the power, 2016-12-21 18:04:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 18:04:25]

Dry run: This issue passed the CQ dry run.

[gsathya, 2016-12-21 18:05:09]

The CQ bit was checked by gsathya@chromium.org

[gsathya, 2016-12-21 18:05:10]

The patchset sent to the CQ was uploaded after l-g-t-m from jgruber@chromium.org
Link to the patchset: https://codereview.chromium.org/2596553002/#ps80001
(title: "fix nits")

[commit-bot: I haz the power, 2016-12-21 18:05:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 18:08:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 18:08:51]

Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/31204)

[Igor Sheludko, 2016-12-21 18:10:04]

The CQ bit was checked by ishell@chromium.org

[Igor Sheludko, 2016-12-21 18:10:05]

lgtm

[commit-bot: I haz the power, 2016-12-21 18:10:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 18:12:09]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1482343804635080,
"parent_rev": "91a7a916789e7c12422f8d78c9820dbd8b486d25", "commit_rev":
"2041c504025d706041e50e52d9e8c7221667492d"}

[commit-bot: I haz the power, 2016-12-21 18:12:15]

Description was changed from

==========
[promises] Move Promise.prototype.catch to TF

This patch also refactors most of PromiseThen into InternalPromiseThen to 
be reused with PromiseCatch and also changes InternalResolvePromise to 
return and not branch.

BUG=v8:5343
==========

to

==========
[promises] Move Promise.prototype.catch to TF

This patch also refactors most of PromiseThen into InternalPromiseThen to 
be reused with PromiseCatch and also changes InternalResolvePromise to 
return and not branch.

BUG=v8:5343

Review-Url: https://codereview.chromium.org/2596553002
Cr-Commit-Position: refs/heads/master@{#41902}
Committed:
https://chromium.googlesource.com/v8/v8/+/2041c504025d706041e50e52d9e8c722166...
==========

[commit-bot: I haz the power, 2016-12-21 18:12:16]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/v8/v8/+/2041c504025d706041e50e52d9e8c722166...