|
|
Chromium Code Reviews|
Created:
4 years ago by gab Modified:
3 years, 11 months ago Reviewers:
Dirk Pranke CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd linux_chromium_tsan_rel_ng to 10% of CQs.
BUG=672860
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_tsan_rel_ng
Review-Url: https://codereview.chromium.org/2596533002
Cr-Commit-Position: refs/heads/master@{#441721}
Committed: https://chromium.googlesource.com/chromium/src/+/1933025de3e1564c12bf7f1b60ca7add98bb62c4
Patch Set 1 #Patch Set 2 : rebase #Messages
Total messages: 23 (13 generated)
gab@chromium.org changed reviewers: + dpranke@chromium.org
Dirk PTAL and let me know when it's safe to land this w.r.t. https://chromium-review.googlesource.com/#/c/422473/ (i.e. right after or need to wait on a roll or something?)
This LGTM. Don't land it until after the master change has landed and the master has been restarted, then it should be safe to land.
Description was changed from ========== Add linux_chromium_tsan_rel_ng to 10% of CQs. Depends on infra CL @ https://chromium-review.googlesource.com/#/c/422473/ BUG=672860 ========== to ========== Add linux_chromium_tsan_rel_ng to 10% of CQs. BUG=672860 ==========
On 2016/12/20 20:33:19, Dirk Pranke wrote: > This LGTM. Don't land it until after the master change has landed and the master > has been restarted, then it should be safe to land. Linux TSan Tests is now green on main waterfall (chromium.memory), landing this :)
The CQ bit was checked by gab@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Add linux_chromium_tsan_rel_ng to 10% of CQs. BUG=672860 ========== to ========== Add linux_chromium_tsan_rel_ng to 10% of CQs. BUG=672860 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_tsan_rel_ng ==========
The CQ bit was unchecked by gab@chromium.org
The CQ bit was checked by gab@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for infra/config/cq.cfg:
While running git apply --index -p1;
error: patch failed: infra/config/cq.cfg:62
error: infra/config/cq.cfg: patch does not apply
Patch: infra/config/cq.cfg
Index: infra/config/cq.cfg
diff --git a/infra/config/cq.cfg b/infra/config/cq.cfg
index
65d868fcbb7f4edc8f562a1e3ae942418ab1f348..6bd93c95fa0ea883bb44ee4dea4918a303177693
100644
--- a/infra/config/cq.cfg
+++ b/infra/config/cq.cfg
@@ -62,6 +62,10 @@ verifiers {
experiment_percentage: 10
}
builders { name: "linux_chromium_rel_ng" }
+ builders {
+ name: "linux_chromium_tsan_rel_ng"
+ experiment_percentage: 10
+ }
}
buckets {
name: "master.tryserver.chromium.mac"
The CQ bit was checked by gab@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for infra/config/cq.cfg:
While running git apply --index -p1;
error: patch failed: infra/config/cq.cfg:62
error: infra/config/cq.cfg: patch does not apply
Patch: infra/config/cq.cfg
Index: infra/config/cq.cfg
diff --git a/infra/config/cq.cfg b/infra/config/cq.cfg
index
65d868fcbb7f4edc8f562a1e3ae942418ab1f348..6bd93c95fa0ea883bb44ee4dea4918a303177693
100644
--- a/infra/config/cq.cfg
+++ b/infra/config/cq.cfg
@@ -62,6 +62,10 @@ verifiers {
experiment_percentage: 10
}
builders { name: "linux_chromium_rel_ng" }
+ builders {
+ name: "linux_chromium_tsan_rel_ng"
+ experiment_percentage: 10
+ }
}
buckets {
name: "master.tryserver.chromium.mac"
The CQ bit was checked by gab@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org Link to the patchset: https://codereview.chromium.org/2596533002/#ps20001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1483641760094640,
"parent_rev": "3f44dbb750d1f7ef1a77fb75f9710eca3225265f", "commit_rev":
"1933025de3e1564c12bf7f1b60ca7add98bb62c4"}
Message was sent while issue was closed.
Description was changed from ========== Add linux_chromium_tsan_rel_ng to 10% of CQs. BUG=672860 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_tsan_rel_ng ========== to ========== Add linux_chromium_tsan_rel_ng to 10% of CQs. BUG=672860 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_tsan_rel_ng Review-Url: https://codereview.chromium.org/2596533002 Cr-Commit-Position: refs/heads/master@{#441721} Committed: https://chromium.googlesource.com/chromium/src/+/1933025de3e1564c12bf7f1b60ca... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/1933025de3e1564c12bf7f1b60ca... |
