Rename blink::SVGSVGElement::CheckIntersectionOrEnclosure enum type.

Rename CheckIntersectionOrEnclosure enum type to GeometryMatchingMode.

This CL renames blink::SVGSVGElement::CheckIntersectionOrEnclosure enum
type to GeometryMatchingMode.

The rename is needed to avoid a naming collision after changing from
Blink to Chromium naming style.  Right now we have an
|CheckIntersectionOrEnclosure| enum type and a
|checkIntersectionOrEnclosure| method (differing by case of the first
character); after a naive rename by the rewrite_to_chrome_style tool we
would end up with |CheckIntersectionOrEnclosure| being the name of both
the type and the method (with both living in the same namespace).

Changing the type name is a workaround that fits into the guidance on
the recommended post-Blink-to-Chromium-rename style suggested by
esprehn@ in https://crbug.com/582312#c17:
- Getters favor not using "Get", ex. FirstChild()
- Unless the type name conflicts, in which case you can either rename
  the type if it's easy and makes sense, or add "Get", ex. GetContext().

BUG=582312
Committed: https://crrev.com/89d3dbf3be30f5a4b98734e5c4089c874d97c530
Cr-Commit-Position: refs/heads/master@{#439947}

[Łukasz Anforowicz, 2016-12-20 18:05:42]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-20 18:06:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 20:47:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 20:47:44]

Dry run: This issue passed the CQ dry run.

[Łukasz Anforowicz, 2016-12-20 22:03:44]

lukasza@chromium.org changed reviewers:
+ dcheng@chromium.org

[Łukasz Anforowicz, 2016-12-20 22:03:44]

Daniel, can you PTAL?  I am not quite happy with the new name, but this name is
used in the "private" section of the type, so this is probably an okay name.

[Łukasz Anforowicz, 2016-12-20 22:05:52]

+fs@ to CC as an FYI - I see that fs@ was recently touching
core/svg/SVGSVGElement.h (FWIW, there is no core/svg/OWNERS - I am not sure who
else might be interested in reviewing the new name).

[fs, 2016-12-20 22:20:26]

On 2016/12/20 at 22:03:44, lukasza wrote:
> Daniel, can you PTAL?  I am not quite happy with the new name, but this name
is used in the "private" section of the type, so this is probably an okay name.

Alternative names may be along the lines of:

GeometryOperation (probably too generic)
GeometryMatchingFunction (or s/Function/Mode/)

anyway, LGTM.

[dcheng, 2016-12-20 22:21:41]

On 2016/12/20 22:20:26, fs wrote:
> On 2016/12/20 at 22:03:44, lukasza wrote:
> > Daniel, can you PTAL?  I am not quite happy with the new name, but this name
> is used in the "private" section of the type, so this is probably an okay
name.
> 
> Alternative names may be along the lines of:
> 
> GeometryOperation (probably too generic)
> GeometryMatchingFunction (or s/Function/Mode/)
> 
> anyway, LGTM.

Defer to fs@ for naming (personally I like
GeometryMatchingFunction/GeometryMatchingMode).

[Łukasz Anforowicz, 2016-12-20 22:24:17]

Description was changed from

==========
Rename blink::SVGSVGElement::CheckIntersectionOrEnclosure enum type.

This CL renames blink::SVGSVGElement::CheckIntersectionOrEnclosure enum
type to CheckIntersectionOrEnclosureFlavour.

The rename is needed to avoid a naming collision after changing from
Blink to Chromium naming style.  Right now we have an
|CheckIntersectionOrEnclosure| enum type and a
|checkIntersectionOrEnclosure| method (differing by case of the first
character); after a naive rename by the rewrite_to_chrome_style tool we
would end up with |CheckIntersectionOrEnclosure| being the name of both
the type and the method (with both living in the same namespace).

Changing the type name is a workaround that fits into the guidance on
the recommended post-Blink-to-Chromium-rename style suggested by
esprehn@ in https://crbug.com/582312#c17:
- Getters favor not using "Get", ex. FirstChild()
- Unless the type name conflicts, in which case you can either rename
  the type if it's easy and makes sense, or add "Get", ex. GetContext().

BUG=582312
==========

to

==========
Rename CheckIntersectionOrEnclosure enum type to GeometryMatchingMode.

This CL renames blink::SVGSVGElement::CheckIntersectionOrEnclosure enum
type to GeometryMatchingMode.

The rename is needed to avoid a naming collision after changing from
Blink to Chromium naming style.  Right now we have an
|CheckIntersectionOrEnclosure| enum type and a
|checkIntersectionOrEnclosure| method (differing by case of the first
character); after a naive rename by the rewrite_to_chrome_style tool we
would end up with |CheckIntersectionOrEnclosure| being the name of both
the type and the method (with both living in the same namespace).

Changing the type name is a workaround that fits into the guidance on
the recommended post-Blink-to-Chromium-rename style suggested by
esprehn@ in https://crbug.com/582312#c17:
- Getters favor not using "Get", ex. FirstChild()
- Unless the type name conflicts, in which case you can either rename
  the type if it's easy and makes sense, or add "Get", ex. GetContext().

BUG=582312
==========

[Łukasz Anforowicz, 2016-12-20 22:25:27]

On 2016/12/20 22:20:26, fs wrote:
> On 2016/12/20 at 22:03:44, lukasza wrote:
> > Daniel, can you PTAL?  I am not quite happy with the new name, but this name
> is used in the "private" section of the type, so this is probably an okay
name.
> 
> Alternative names may be along the lines of:
> 
> GeometryOperation (probably too generic)
> GeometryMatchingFunction (or s/Function/Mode/)
> 
> anyway, LGTM.

Thank you for the suggestions.  I like GeometryMatchingMode (parameters of this
type are named |mode| in a few places).  Done.

[Łukasz Anforowicz, 2016-12-20 22:27:02]

The CQ bit was checked by lukasza@chromium.org

[Łukasz Anforowicz, 2016-12-20 22:27:02]

The patchset sent to the CQ was uploaded after l-g-t-m from fs@opera.com
Link to the patchset: https://codereview.chromium.org/2596503002/#ps20001
(title: "s/CheckIntersectionOrEnclosureFlavour/GeometryMatchingMode/")

[commit-bot: I haz the power, 2016-12-20 22:27:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 00:18:01]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482272822321420,
"parent_rev": "9467bfc6839828d8096cb4cec35c5b8ced41fcc8", "commit_rev":
"f942b4dac1181e8ff6bad405377a26be4599cb65"}

[commit-bot: I haz the power, 2016-12-21 00:18:28]

Description was changed from

==========
Rename CheckIntersectionOrEnclosure enum type to GeometryMatchingMode.

This CL renames blink::SVGSVGElement::CheckIntersectionOrEnclosure enum
type to GeometryMatchingMode.

The rename is needed to avoid a naming collision after changing from
Blink to Chromium naming style.  Right now we have an
|CheckIntersectionOrEnclosure| enum type and a
|checkIntersectionOrEnclosure| method (differing by case of the first
character); after a naive rename by the rewrite_to_chrome_style tool we
would end up with |CheckIntersectionOrEnclosure| being the name of both
the type and the method (with both living in the same namespace).

Changing the type name is a workaround that fits into the guidance on
the recommended post-Blink-to-Chromium-rename style suggested by
esprehn@ in https://crbug.com/582312#c17:
- Getters favor not using "Get", ex. FirstChild()
- Unless the type name conflicts, in which case you can either rename
  the type if it's easy and makes sense, or add "Get", ex. GetContext().

BUG=582312
==========

to

==========
Rename CheckIntersectionOrEnclosure enum type to GeometryMatchingMode.

This CL renames blink::SVGSVGElement::CheckIntersectionOrEnclosure enum
type to GeometryMatchingMode.

The rename is needed to avoid a naming collision after changing from
Blink to Chromium naming style.  Right now we have an
|CheckIntersectionOrEnclosure| enum type and a
|checkIntersectionOrEnclosure| method (differing by case of the first
character); after a naive rename by the rewrite_to_chrome_style tool we
would end up with |CheckIntersectionOrEnclosure| being the name of both
the type and the method (with both living in the same namespace).

Changing the type name is a workaround that fits into the guidance on
the recommended post-Blink-to-Chromium-rename style suggested by
esprehn@ in https://crbug.com/582312#c17:
- Getters favor not using "Get", ex. FirstChild()
- Unless the type name conflicts, in which case you can either rename
  the type if it's easy and makes sense, or add "Get", ex. GetContext().

BUG=582312

Review-Url: https://codereview.chromium.org/2596503002
==========

[commit-bot: I haz the power, 2016-12-21 00:18:29]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-21 00:20:31]

Description was changed from

==========
Rename CheckIntersectionOrEnclosure enum type to GeometryMatchingMode.

This CL renames blink::SVGSVGElement::CheckIntersectionOrEnclosure enum
type to GeometryMatchingMode.

The rename is needed to avoid a naming collision after changing from
Blink to Chromium naming style.  Right now we have an
|CheckIntersectionOrEnclosure| enum type and a
|checkIntersectionOrEnclosure| method (differing by case of the first
character); after a naive rename by the rewrite_to_chrome_style tool we
would end up with |CheckIntersectionOrEnclosure| being the name of both
the type and the method (with both living in the same namespace).

Changing the type name is a workaround that fits into the guidance on
the recommended post-Blink-to-Chromium-rename style suggested by
esprehn@ in https://crbug.com/582312#c17:
- Getters favor not using "Get", ex. FirstChild()
- Unless the type name conflicts, in which case you can either rename
  the type if it's easy and makes sense, or add "Get", ex. GetContext().

BUG=582312

Review-Url: https://codereview.chromium.org/2596503002
==========

to

==========
Rename CheckIntersectionOrEnclosure enum type to GeometryMatchingMode.

This CL renames blink::SVGSVGElement::CheckIntersectionOrEnclosure enum
type to GeometryMatchingMode.

The rename is needed to avoid a naming collision after changing from
Blink to Chromium naming style.  Right now we have an
|CheckIntersectionOrEnclosure| enum type and a
|checkIntersectionOrEnclosure| method (differing by case of the first
character); after a naive rename by the rewrite_to_chrome_style tool we
would end up with |CheckIntersectionOrEnclosure| being the name of both
the type and the method (with both living in the same namespace).

Changing the type name is a workaround that fits into the guidance on
the recommended post-Blink-to-Chromium-rename style suggested by
esprehn@ in https://crbug.com/582312#c17:
- Getters favor not using "Get", ex. FirstChild()
- Unless the type name conflicts, in which case you can either rename
  the type if it's easy and makes sense, or add "Get", ex. GetContext().

BUG=582312

Committed: https://crrev.com/89d3dbf3be30f5a4b98734e5c4089c874d97c530
Cr-Commit-Position: refs/heads/master@{#439947}
==========

[commit-bot: I haz the power, 2016-12-21 00:20:32]

Patchset 2 (id:??) landed as
https://crrev.com/89d3dbf3be30f5a4b98734e5c4089c874d97c530
Cr-Commit-Position: refs/heads/master@{#439947}