[Android] Generate html file for test runner trace instead of json.

[Android] Generate html file for test runner trace instead of json.

Before would have to download the uploaded json, and then view it in the
trace viewer. This uses the trace2html bin in catapult to generate the
html file so that all you have to do is download the html file.

Committed: https://crrev.com/c56d9aa584599843a31ebb688cff22d7d66d3621
Cr-Commit-Position: refs/heads/master@{#439964}

[rnephew (Reviews Here), 2016-12-20 17:34:46]

rnephew@chromium.org changed reviewers:
+ jbudorick@chromium.org, mikecase@chromium.org

[jbudorick, 2016-12-20 17:38:06]

Are there circumstances in which we'd prefer to have the JSON rather than the
HTML? Should we support both?

https://codereview.chromium.org/2596443004/diff/1/build/android/pylib/__init_...
File build/android/pylib/__init__.py (right):

https://codereview.chromium.org/2596443004/diff/1/build/android/pylib/__init_...
build/android/pylib/__init__.py:9: os.path.dirname(__file__), '..', '..', '..',
'third_party', 'catapult',
We should probably just extract the catapult path into a constant.

https://codereview.chromium.org/2596443004/diff/1/build/android/test_runner.p...
File build/android/test_runner.pydeps (right):

https://codereview.chromium.org/2596443004/diff/1/build/android/test_runner.p...
build/android/test_runner.pydeps:2: #   build/print_python_deps.py --output
build/android/test_runner.pydeps build/android/test_runner.py
What happened here?

[rnephew (Reviews Here), 2016-12-20 17:52:57]

The only use for the json file is to generate the trace. I cannot come up with
any convincing reason to support both.

https://codereview.chromium.org/2596443004/diff/1/build/android/pylib/__init_...
File build/android/pylib/__init__.py (right):

https://codereview.chromium.org/2596443004/diff/1/build/android/pylib/__init_...
build/android/pylib/__init__.py:9: os.path.dirname(__file__), '..', '..', '..',
'third_party', 'catapult',
On 2016/12/20 17:38:05, jbudorick wrote:
> We should probably just extract the catapult path into a constant.

Done.

https://codereview.chromium.org/2596443004/diff/1/build/android/test_runner.p...
File build/android/test_runner.pydeps (right):

https://codereview.chromium.org/2596443004/diff/1/build/android/test_runner.p...
build/android/test_runner.pydeps:2: #   build/print_python_deps.py --output
build/android/test_runner.pydeps build/android/test_runner.py
On 2016/12/20 17:38:06, jbudorick wrote:
> What happened here?

I.. have no clue. I just uploaded a new patch and it didn't complain... I have
no clue how pydeps works, anyone I should ask?

[mikecase (-- gone --), 2016-12-20 18:35:41]

lgtm with nit. also, before committing I would look into what happened to pydeps
to see if its working right

https://codereview.chromium.org/2596443004/diff/20001/build/android/pylib/loc...
File build/android/pylib/local/device/local_device_test_run.py (right):

https://codereview.chromium.org/2596443004/diff/20001/build/android/pylib/loc...
build/android/pylib/local/device/local_device_test_run.py:208: def
_JsonToTrace(json_path, save_path):
nit: maybe rename this to like

_JsonTraceToHTML ?

and maybe rename save_path to html_path?

if this makes sense

[rnephew (Reviews Here), 2016-12-20 18:42:51]

Me and john talked offline, the pydeps file appears to be abs not relative path
now. I ran the generator on ToT and it did the same thing so this is likely the
expected behavior now.

https://codereview.chromium.org/2596443004/diff/20001/build/android/pylib/loc...
File build/android/pylib/local/device/local_device_test_run.py (right):

https://codereview.chromium.org/2596443004/diff/20001/build/android/pylib/loc...
build/android/pylib/local/device/local_device_test_run.py:208: def
_JsonToTrace(json_path, save_path):
On 2016/12/20 18:35:40, mikecase wrote:
> nit: maybe rename this to like
> 
> _JsonTraceToHTML ?
> 
> and maybe rename save_path to html_path?
> 
> if this makes sense

Done.

[rnephew (Reviews Here), 2016-12-20 18:45:05]

rnephew@chromium.org changed reviewers:
+ agrieve@chromium.org

[rnephew (Reviews Here), 2016-12-20 18:45:05]

Talked to John more offline. He wants to make sure that its expected before we
land. Adding agrieve@ who wrote the pydeps stuff.

[agrieve, 2016-12-20 19:27:03]

If you look at the "generated by running" comment at the top of the .pydeps
file, you'll notice that the new one is missing the --root parameter. I think
that's the issue.

https://codereview.chromium.org/2596443004/diff/40001/build/android/pylib/loc...
File build/android/pylib/local/device/local_device_perf_test_run.py (right):

https://codereview.chromium.org/2596443004/diff/40001/build/android/pylib/loc...
build/android/pylib/local/device/local_device_perf_test_run.py:469:
self._JsonToTrace(self._test_instance.trace_output + '.json',
nit: shouldn't call static method via "self". Use
LocalDeviceTestRun._JsonToTrace

[rnephew (Reviews Here), 2016-12-20 19:37:10]

Patchset #4 (id:60001) has been deleted

[rnephew (Reviews Here), 2016-12-20 19:37:56]

Yep, that fixed the pydeps issue. Thanks!

https://codereview.chromium.org/2596443004/diff/40001/build/android/pylib/loc...
File build/android/pylib/local/device/local_device_perf_test_run.py (right):

https://codereview.chromium.org/2596443004/diff/40001/build/android/pylib/loc...
build/android/pylib/local/device/local_device_perf_test_run.py:469:
self._JsonToTrace(self._test_instance.trace_output + '.json',
On 2016/12/20 19:27:03, agrieve wrote:
> nit: shouldn't call static method via "self". Use
> LocalDeviceTestRun._JsonToTrace

Done.

[rnephew (Reviews Here), 2016-12-20 20:51:54]

The CQ bit was checked by rnephew@chromium.org

[rnephew (Reviews Here), 2016-12-20 20:51:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
mikecase@chromium.org
Link to the patchset: https://codereview.chromium.org/2596443004/#ps80001
(title: "agrieves comments")

[commit-bot: I haz the power, 2016-12-20 20:52:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 23:58:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 23:58:59]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[rnephew (Reviews Here), 2016-12-21 00:00:59]

The CQ bit was checked by rnephew@chromium.org

[commit-bot: I haz the power, 2016-12-21 00:02:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 01:26:17]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1482278459609440,
"parent_rev": "c50a48b74dea8e73fd7fc4e4e8b8f218cd626470", "commit_rev":
"aec559567af77565659c465702878c4cd6e296c0"}

[commit-bot: I haz the power, 2016-12-21 01:27:34]

Description was changed from

==========
[Android] Generate html file for test runner trace instead of json.

Before would have to download the uploaded json, and then view it in the
trace viewer. This uses the trace2html bin in catapult to generate the
html file so that all you have to do is download the html file.
==========

to

==========
[Android] Generate html file for test runner trace instead of json.

Before would have to download the uploaded json, and then view it in the
trace viewer. This uses the trace2html bin in catapult to generate the
html file so that all you have to do is download the html file.

Review-Url: https://codereview.chromium.org/2596443004
==========

[commit-bot: I haz the power, 2016-12-21 01:27:35]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-12-21 01:29:36]

Description was changed from

==========
[Android] Generate html file for test runner trace instead of json.

Before would have to download the uploaded json, and then view it in the
trace viewer. This uses the trace2html bin in catapult to generate the
html file so that all you have to do is download the html file.

Review-Url: https://codereview.chromium.org/2596443004
==========

to

==========
[Android] Generate html file for test runner trace instead of json.

Before would have to download the uploaded json, and then view it in the
trace viewer. This uses the trace2html bin in catapult to generate the
html file so that all you have to do is download the html file.

Committed: https://crrev.com/c56d9aa584599843a31ebb688cff22d7d66d3621
Cr-Commit-Position: refs/heads/master@{#439964}
==========

[commit-bot: I haz the power, 2016-12-21 01:29:37]

Patchset 4 (id:??) landed as
https://crrev.com/c56d9aa584599843a31ebb688cff22d7d66d3621
Cr-Commit-Position: refs/heads/master@{#439964}