Update Windows-specific docs for the clang rewriting tool.

Update Windows-specific docs for the clang rewriting tool.

R=dcheng@chromium.org

Committed: https://crrev.com/ca6b31b571df80b7e2af847d9c9c0fc6f6e40c51
Cr-Commit-Position: refs/heads/master@{#440516}

[danakj, 2016-12-22 20:40:01]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-22 20:40:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 20:49:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-22 20:49:44]

Dry run: This issue passed the CQ dry run.

[dcheng, 2016-12-22 21:31:46]

LGTM

https://codereview.chromium.org/2596383002/diff/1/docs/clang_tool_refactoring.md
File docs/clang_tool_refactoring.md (right):

https://codereview.chromium.org/2596383002/diff/1/docs/clang_tool_refactoring...
docs/clang_tool_refactoring.md:133: On windows to avoid this flag, you must also
run the
Nit:
NOTE: On Windows, use generate_win_compdb.py to generate the compile DB instead
of using the --generate-compdb flag.

[danakj, 2016-12-22 21:41:21]

PTAL

[dcheng, 2016-12-22 21:43:03]

LGTM with a nit

https://codereview.chromium.org/2596383002/diff/20001/docs/clang_tool_refacto...
File docs/clang_tool_refactoring.md (right):

https://codereview.chromium.org/2596383002/diff/20001/docs/clang_tool_refacto...
docs/clang_tool_refactoring.md:127: tools/clang/scripts/generate_win_compdb.py
Nit: I think this takes an optional path to the build for, might be nice to
include for consistency.

[danakj, 2016-12-22 21:47:30]

The CQ bit was checked by danakj@chromium.org

[danakj, 2016-12-22 21:47:30]

The patchset sent to the CQ was uploaded after l-g-t-m from dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2596383002/#ps40001
(title: "windows-clang-tool: .")

[commit-bot: I haz the power, 2016-12-22 21:47:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 22:05:58]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1482443250347430,
"parent_rev": "33407a4eee628084324144790228c809b5d61a1a", "commit_rev":
"c0739b6225864e648ae86d0bf2f1a7244b5a559e"}

[commit-bot: I haz the power, 2016-12-22 22:06:25]

Description was changed from

==========
Update Windows-specific docs for the clang rewriting tool.

R=dcheng@chromium.org
==========

to

==========
Update Windows-specific docs for the clang rewriting tool.

R=dcheng@chromium.org

Review-Url: https://codereview.chromium.org/2596383002
==========

[commit-bot: I haz the power, 2016-12-22 22:06:25]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-22 22:09:51]

Description was changed from

==========
Update Windows-specific docs for the clang rewriting tool.

R=dcheng@chromium.org

Review-Url: https://codereview.chromium.org/2596383002
==========

to

==========
Update Windows-specific docs for the clang rewriting tool.

R=dcheng@chromium.org

Committed: https://crrev.com/ca6b31b571df80b7e2af847d9c9c0fc6f6e40c51
Cr-Commit-Position: refs/heads/master@{#440516}
==========

[commit-bot: I haz the power, 2016-12-22 22:09:52]

Patchset 3 (id:??) landed as
https://crrev.com/ca6b31b571df80b7e2af847d9c9c0fc6f6e40c51
Cr-Commit-Position: refs/heads/master@{#440516}