Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 2596283002: Include-what-you-use for ThreadTaskRunnerHandle. (Closed)

Created:
4 years ago by fdoray
Modified:
3 years, 12 months ago
Reviewers:
gab, brettw
CC:
chromium-reviews, sadrul, achuith+watch_chromium.org, johnme+watch_chromium.org, kmarshall+watch-blimp_chromium.org, alokp+watch_chromium.org, shaktisahu+watch-blimp_chromium.org, toyoshim+midi_chromium.org, bgoldman+watch-blimp_chromium.org, sebsg+autofillwatch_chromium.org, gcasto+watch-blimp_chromium.org, einbinder+watch-test-runner_chromium.org, khushalsagar+watch-blimp_chromium.org, kalyank, harkness+watch_chromium.org, scf+watch-blimp_chromium.org, mlamouri+watch-content_chromium.org, ntp-dev+reviews_chromium.org, Randy Smith (Not in Mondays), loading-reviews_chromium.org, jochen+watch_chromium.org, sdefresne+watch_chromium.org, rjkroege, mlamouri+watch-test-runner_chromium.org, tfarina, avayvod+watch_chromium.org, perumaal+watch-blimp_chromium.org, mac-reviews_chromium.org, estade+watch_chromium.org, isheriff+watch_chromium.org, mmenke, viettrungluu+watch_chromium.org, scheib+watch_chromium.org, lhchavez+watch_chromium.org, kinuko+watch, iclelland+watch_chromium.org, jam, chasej+watch_chromium.org, marcinjb+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, vabr+watchlistautofill_chromium.org, chromium-apps-reviews_chromium.org, alemate+watch_chromium.org, jsbell+serviceworker_chromium.org, nhiroki, shimazu+serviceworker_chromium.org, sriramsr+watch-blimp_chromium.org, serviceworker-reviews, jshin+watch_chromium.org, horo+watch_chromium.org, yusukes+watch_chromium.org, zea+watch_chromium.org, hidehiko+watch_chromium.org, browser-components-watch_chromium.org, yzshen+watch_chromium.org, nyquist+watch-blimp_chromium.org, mlamouri+watch-media_chromium.org, miu+watch_chromium.org, extensions-reviews_chromium.org, chromoting-reviews_chromium.org, abarth-chromium, darin-cc_chromium.org, jkarlin+watch_chromium.org, xjz+watch_chromium.org, blink-worker-reviews_chromium.org, elijahtaylor+arcwatch_chromium.org, imcheng+watch_chromium.org, rouslan+autofill_chromium.org, jasonroberts+watch_google.com, oshima+watch_chromium.org, kinuko+cache_chromium.org, piman+watch_chromium.org, sync-reviews_chromium.org, anandc+watch-blimp_chromium.org, shalamov, tbansal+watch-data-reduction-proxy_chromium.org, Aaron Boodman, cmumford, ortuno+watch_chromium.org, davemoore+watch_chromium.org, erickung+watch_chromium.org, pkl (ping after 24h if needed), qsr+mojo_chromium.org, tzik, posciak+watch_chromium.org, apacible+watch_chromium.org, darin (slow to review), cbentzel+watch_chromium.org, maniscalco+watch-blimp_chromium.org, gavinp+disk_chromium.org, jbauman+watch_chromium.org, wanming.lin, vabr+watchlistpasswordmanager_chromium.org, Peter Beverloo, feature-media-reviews_chromium.org, fuzzing_chromium.org, mcasas+watch+vc_chromium.org, gcasto+watchlist_chromium.org, jsbell+idb_chromium.org, cc-bugs_chromium.org, michaeln, mathp+autofillwatch_chromium.org, steimel+watch-blimp_chromium.org, jdonnelly+autofillwatch_chromium.org, kinuko+serviceworker, danakj+watch_chromium.org, dtrainor+watch-blimp_chromium.org, Mikhail
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Include-what-you-use for ThreadTaskRunnerHandle. This CL adds #include "base/threading/thread_task_runner_handle.h" to any .h/.cc/.cpp/.mm file that contains the string "ThreadTaskRunnerHandle::" on a line that doesn't start with "//" and whose corresponding .h file doesn't already contain the include. .h files are processed first so that the #include is not added to a .cc/.cpp/.mm file if it is also added to the corresponding .h file. tools/sort-headers.py was applied to affected files. TBR=brettw@chromium.org BUG=675631 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Committed: https://crrev.com/a19b77026d3ba89c5c400d1843e1a40718ff25a4 Cr-Commit-Position: refs/heads/master@{#440628}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -0 lines) Patch
M ash/mus/window_manager_application.cc View 1 chunk +1 line, -0 lines 0 comments Download
M blimp/client/test/compositor/blimp_compositor_with_fake_host.cc View 1 chunk +1 line, -0 lines 0 comments Download
M blimp/engine/feature/engine_render_widget_feature.cc View 1 chunk +1 line, -0 lines 0 comments Download
M cc/test/fake_layer_tree_host.cc View 1 chunk +1 line, -0 lines 0 comments Download
M cc/test/test_layer_tree_host_base.cc View 1 chunk +1 line, -0 lines 0 comments Download
M cc/trees/tree_synchronizer_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/arc/arc_session_manager.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller_browsertest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/resource_reporter/resource_reporter.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/component_updater/subresource_filter_component_installer_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/gcd_private/gcd_private_apitest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/media/cast_remoting_sender.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/previews/previews_infobar_delegate_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/previews/previews_infobar_tab_helper_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/push_messaging/push_messaging_service_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/signin/mutable_profile_oauth2_token_service_delegate_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/ash/launcher/arc_app_deferred_launcher_controller.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa.mm View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/prefs/prefs_tab_helper.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/test/test_browser_dialog.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/l10n_util.cc View 2 1 chunk +1 line, -0 lines 0 comments Download
M components/autofill/content/renderer/password_autofill_agent.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/autofill/content/renderer/password_generation_agent.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/autofill/core/browser/payments/full_card_request_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/browser_sync/abstract_profile_sync_service_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/browser_sync/profile_sync_service_bookmark_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/browser_sync/profile_sync_test_util.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/cronet/stale_host_resolver_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/invalidation/impl/ticl_profile_settings_provider_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/ntp_snippets/remote/remote_suggestions_provider_impl.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M components/ntp_snippets/sessions/foreign_sessions_suggestions_provider.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/ntp_tiles/popular_sites_impl.cc View 2 1 chunk +1 line, -0 lines 0 comments Download
M components/password_manager/core/browser/mock_password_store.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/password_manager/core/browser/password_store_default_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/ssl_errors/error_classification_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/background_sync/background_sync_browsertest.cc View 2 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/bluetooth/bluetooth_device_chooser_controller.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/cache_storage/cache_storage_manager.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/compositor/vulkan_browser_compositor_output_surface.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/indexed_db/cursor_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/indexed_db/database_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/loader/async_revalidation_driver_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/loader/resource_scheduler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/plugin_service_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/media/audio_input_renderer_host_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/media/audio_renderer_host_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_read_from_cache_job.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_registration.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/child/indexed_db/indexed_db_callbacks_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/child/indexed_db/indexed_db_database_callbacks_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/child/web_url_loader_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/service_manager/service_manager_connection_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/gpu/gpu_child_thread.cc View 2 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_android.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/media/midi_message_filter.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/media/rtc_certificate_generator.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/media/video_track_adapter.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/media/webrtc/webrtc_video_capturer_adapter.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/pepper/pepper_video_encoder_host.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/presentation/presentation_dispatcher.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_widget.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/test/layouttest_support.cc View 1 chunk +1 line, -0 lines 0 comments Download
M device/generic_sensor/platform_sensor_and_provider_unittest_linux.cc View 1 chunk +1 line, -0 lines 0 comments Download
M device/generic_sensor/platform_sensor_reader_win.cc View 1 chunk +1 line, -0 lines 0 comments Download
M device/generic_sensor/sensor_provider_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M device/serial/serial_service_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M device/wake_lock/wake_lock_service_context_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/renderer/api/display_source/wifi_display/wifi_display_media_manager.cc View 2 1 chunk +1 line, -0 lines 0 comments Download
M extensions/renderer/script_injection_manager.cc View 1 chunk +1 line, -0 lines 0 comments Download
M google_apis/gcm/engine/connection_factory_impl_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M headless/public/util/testing/generic_url_request_mocks.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/passwords/ios_chrome_password_store_factory.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/web_resource/web_resource_util.cc View 2 1 chunk +1 line, -0 lines 0 comments Download
M ios/net/http_cache_helper.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ipc/ipc_test_base.cc View 1 chunk +1 line, -0 lines 0 comments Download
M media/blink/webaudiosourceprovider_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M media/cast/test/receiver.cc View 1 chunk +1 line, -0 lines 0 comments Download
M media/filters/chunk_demuxer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M media/filters/ffmpeg_video_decoder.cc View 1 chunk +1 line, -0 lines 0 comments Download
M media/filters/vpx_video_decoder.cc View 1 chunk +1 line, -0 lines 0 comments Download
M media/gpu/ipc/service/gpu_video_encode_accelerator.cc View 1 chunk +1 line, -0 lines 0 comments Download
M media/gpu/v4l2_slice_video_decode_accelerator.cc View 1 chunk +1 line, -0 lines 0 comments Download
M media/gpu/vaapi_video_encode_accelerator.cc View 1 chunk +1 line, -0 lines 0 comments Download
M media/gpu/video_encode_accelerator_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M media/mojo/clients/mojo_renderer_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M media/remoting/remote_renderer_impl.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M media/remoting/remote_renderer_impl_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/cpp/bindings/tests/bindings_perftest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/http/http_network_transaction_ssl_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/http/http_stream_factory_impl_job_controller.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/chromium/bidirectional_stream_quic_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/chromium/bidirectional_stream_quic_impl_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/chromium/quic_end_to_end_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/chromium/quic_http_stream.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/spdy/bidirectional_stream_spdy_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/spdy/spdy_http_stream_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/test/embedded_test_server/embedded_test_server_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/url_request/url_request_context.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/url_request/url_request_data_job_fuzzer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/url_request/url_request_file_dir_job_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/signaling/delegating_signal_strategy.cc View 1 chunk +1 line, -0 lines 0 comments Download
M services/service_manager/public/cpp/lib/service_context.cc View 1 chunk +1 line, -0 lines 0 comments Download
M services/ui/surfaces/display_compositor.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/mus/desktop_window_tree_host_mus.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 30 (22 generated)
fdoray
PTAL
4 years ago (2016-12-22 16:23:59 UTC) #7
gab
Add sequencification bug as BUG= ? Suggested title: "Include-what-you-use for ThreadTaskRunnerHandle." lgtm otherwise (feel free ...
4 years ago (2016-12-22 20:38:51 UTC) #10
fdoray
TBR=brettw@chromium.org
3 years, 12 months ago (2016-12-23 12:32:23 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2596283002/20001
3 years, 12 months ago (2016-12-23 12:32:48 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-clang/builds/13031) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 12 months ago (2016-12-23 12:40:57 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2596283002/40001
3 years, 12 months ago (2016-12-23 12:45:55 UTC) #25
commit-bot: I haz the power
Committed patchset #3 (id:40001)
3 years, 12 months ago (2016-12-23 14:20:08 UTC) #28
commit-bot: I haz the power
3 years, 12 months ago (2016-12-23 14:22:14 UTC) #30
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a19b77026d3ba89c5c400d1843e1a40718ff25a4
Cr-Commit-Position: refs/heads/master@{#440628}

Powered by Google App Engine
This is Rietveld 408576698