Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 2596243003: [ios] Added a CHECK to didCommitNavigation: to debug crbug.com/676340. (Closed)

Created:
4 years ago by Eugene But (OOO till 7-30)
Modified:
3 years, 11 months ago
Reviewers:
kkhorimoto
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Added a CHECK to didCommitNavigation: to debug crbug.com/676340. didCommitNavigation: crashes if NavigationManager is empty. This new CHECK crashes if MN is empty and |didStartProvisionalNavigation| was called. If this CHECK is hit it means that |didStartProvisionalNavigation| was called as expected but it did not call |registerLoadRequest|. If that's the case then |didStartProvisionalNavigation| needs to be changed to always call |registerLoadRequest| if MN is empty. BUG=676458 Committed: https://crrev.com/272901feb7b3ed31f1aa50e50b799512f1152917 Cr-Commit-Position: refs/heads/master@{#440796}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M ios/web/web_state/ui/crw_web_controller.mm View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Eugene But (OOO till 7-30)
4 years ago (2016-12-22 22:40:23 UTC) #4
kkhorimoto
lgtm
3 years, 12 months ago (2016-12-27 21:52:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2596243003/1
3 years, 12 months ago (2016-12-27 22:05:57 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 12 months ago (2016-12-27 22:15:22 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:47:30 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/272901feb7b3ed31f1aa50e50b799512f1152917
Cr-Commit-Position: refs/heads/master@{#440796}

Powered by Google App Engine
This is Rietveld 408576698