Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1833)

Unified Diff: content/renderer/input/render_widget_input_handler_delegate.h

Issue 2596193002: Clean up names and remove unnecessary parameter (Closed)
Patch Set: change parameter name, pass parameter directly Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/input/render_widget_input_handler_delegate.h
diff --git a/content/renderer/input/render_widget_input_handler_delegate.h b/content/renderer/input/render_widget_input_handler_delegate.h
index 4c245f2eb0060b8d292b1e4c7ff34578dae364b0..6fd131283c9a2576114a7b2fcec5570e5aa0ca54 100644
--- a/content/renderer/input/render_widget_input_handler_delegate.h
+++ b/content/renderer/input/render_widget_input_handler_delegate.h
@@ -24,12 +24,7 @@ namespace content {
class RenderWidgetInputHandler;
-enum class ShowIme { IF_NEEDED, HIDE_IME };
-
-enum class ChangeSource {
- FROM_NON_IME,
- FROM_IME,
-};
+enum class ShowIme { IF_NEEDED, DO_NOT_SHOW };
aelias_OOO_until_Jul13 2017/01/04 20:11:01 I think I'd prefer the following naming: enum cla
Changwan Ryu 2017/01/05 08:47:03 I agree that virtual keyboard is much clearer than
// Consumers of RenderWidgetInputHandler implement this delegate in order to
// transport input handling information across processes.
@@ -70,13 +65,7 @@ class CONTENT_EXPORT RenderWidgetInputHandlerDelegate {
// |show_ime| should be ShowIme::IF_NEEDED iff the update may cause the ime to
// be displayed, e.g. after a tap on an input field on mobile.
- // |change_source| should be ChangeSource::FROM_NON_IME when the renderer has
- // to wait for the browser to acknowledge the change before the renderer
- // handles any more IME events. This is when the text change did not originate
- // from the IME in the browser side, such as changes by JavaScript or
- // autofill.
- virtual void UpdateTextInputState(ShowIme show_ime,
- ChangeSource change_source) = 0;
+ virtual void UpdateTextInputState(ShowIme show_ime) = 0;
// Notifies that a gesture event is about to be handled.
// Returns true if no further handling is needed. In that case, the event

Powered by Google App Engine
This is Rietveld 408576698