Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 2596023002: DevTools: remove ruler bar from the main flamechart (Closed)

Created:
4 years ago by alph
Modified:
4 years ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: remove ruler bar from the main flamechart There's already one on the network flamechart. Committed: https://crrev.com/9e3be0d4741ad02b004f60b8b7affe2552dabb11 Cr-Commit-Position: refs/heads/master@{#440576}

Patch Set 1 #

Patch Set 2 : rebaseline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -11 lines) Patch
M third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileFlameChart.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui_lazy/FlameChart.js View 7 chunks +14 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui_lazy/TimelineGrid.js View 3 chunks +9 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
alph
4 years ago (2016-12-21 20:23:05 UTC) #2
pfeldman
lgtm
4 years ago (2016-12-22 22:54:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2596023002/1
4 years ago (2016-12-22 23:01:32 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/127635) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years ago (2016-12-22 23:04:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2596023002/20001
4 years ago (2016-12-23 00:04:16 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-23 01:37:46 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-23 01:41:06 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9e3be0d4741ad02b004f60b8b7affe2552dabb11
Cr-Commit-Position: refs/heads/master@{#440576}

Powered by Google App Engine
This is Rietveld 408576698