Add Butler global tags.

Add Butler global tags.

Add global tags to the LogDog Butler. These tags will be automatically
applied to each stream that the Butler creates.

BUG=chromium:676409
TEST=local
  - Ran with "file" output type, observed successful application and
    merging of global flags.

Review-Url: https://codereview.chromium.org/2595993002
Committed: https://github.com/luci/luci-go/commit/294de93752002bee56028b1138c2c58d0837a97d

[dnj, 2016-12-21 19:55:32]

dnj@chromium.org changed reviewers:
+ estaab@chromium.org, seanmccullough@chromium.org

[dnj, 2016-12-21 19:55:33]

PTAL

[seanmccullough1, 2016-12-22 01:46:09]

seanmccullough@google.com changed reviewers:
+ seanmccullough@google.com

[seanmccullough1, 2016-12-22 01:46:10]

lgtm

https://codereview.chromium.org/2595993002/diff/1/logdog/client/butler/butler.go
File logdog/client/butler/butler.go (right):

https://codereview.chromium.org/2595993002/diff/1/logdog/client/butler/butler...
logdog/client/butler/butler.go:409: streamTags := make(map[string]string,
l+len(p.Tags))
why not just assign to/mutate p.Tags?

[dnj, 2016-12-22 01:49:38]

https://codereview.chromium.org/2595993002/diff/1/logdog/client/butler/butler.go
File logdog/client/butler/butler.go (right):

https://codereview.chromium.org/2595993002/diff/1/logdog/client/butler/butler...
logdog/client/butler/butler.go:409: streamTags := make(map[string]string,
l+len(p.Tags))
On 2016/12/22 01:46:10, seanmccullough1 wrote:
> why not just assign to/mutate p.Tags?

Hmm good point, will do that.

[dnj, 2016-12-22 01:50:26]

The CQ bit was checked by dnj@chromium.org

[dnj, 2016-12-22 01:50:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
seanmccullough@google.com
Link to the patchset: https://codereview.chromium.org/2595993002/#ps20001
(title: "Mutate existing map.")

[commit-bot: I haz the power, 2016-12-22 01:50:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 01:56:25]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482371426971780,
"parent_rev": "464d9ab6bc1614432afa076e4416b0033028cd7b", "commit_rev":
"294de93752002bee56028b1138c2c58d0837a97d"}

[commit-bot: I haz the power, 2016-12-22 01:56:28]

Description was changed from

==========
Add Butler global tags.

Add global tags to the LogDog Butler. These tags will be automatically
applied to each stream that the Butler creates.

BUG=chromium:676409
TEST=local
  - Ran with "file" output type, observed successful application and
    merging of global flags.
==========

to

==========
Add Butler global tags.

Add global tags to the LogDog Butler. These tags will be automatically
applied to each stream that the Butler creates.

BUG=chromium:676409
TEST=local
  - Ran with "file" output type, observed successful application and
    merging of global flags.

Review-Url: https://codereview.chromium.org/2595993002
Committed:
https://github.com/luci/luci-go/commit/294de93752002bee56028b1138c2c58d0837a97d
==========

[commit-bot: I haz the power, 2016-12-22 01:56:29]

Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/294de93752002bee56028b1138c2c58d0837a97d