Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 2595993002: Add Butler global tags. (Closed)

Created:
3 years, 12 months ago by dnj
Modified:
3 years, 12 months ago
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Add Butler global tags. Add global tags to the LogDog Butler. These tags will be automatically applied to each stream that the Butler creates. BUG=chromium:676409 TEST=local - Ran with "file" output type, observed successful application and merging of global flags. Review-Url: https://codereview.chromium.org/2595993002 Committed: https://github.com/luci/luci-go/commit/294de93752002bee56028b1138c2c58d0837a97d

Patch Set 1 #

Total comments: 2

Patch Set 2 : Mutate existing map. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -1 line) Patch
M logdog/client/butler/butler.go View 1 3 chunks +17 lines, -0 lines 0 comments Download
M logdog/client/cmd/logdog_butler/main.go View 4 chunks +6 lines, -0 lines 0 comments Download
M logdog/client/cmd/logdog_butler/stream.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
dnj
PTAL
3 years, 12 months ago (2016-12-21 19:55:33 UTC) #2
seanmccullough1
lgtm https://codereview.chromium.org/2595993002/diff/1/logdog/client/butler/butler.go File logdog/client/butler/butler.go (right): https://codereview.chromium.org/2595993002/diff/1/logdog/client/butler/butler.go#newcode409 logdog/client/butler/butler.go:409: streamTags := make(map[string]string, l+len(p.Tags)) why not just assign ...
3 years, 12 months ago (2016-12-22 01:46:10 UTC) #4
dnj
https://codereview.chromium.org/2595993002/diff/1/logdog/client/butler/butler.go File logdog/client/butler/butler.go (right): https://codereview.chromium.org/2595993002/diff/1/logdog/client/butler/butler.go#newcode409 logdog/client/butler/butler.go:409: streamTags := make(map[string]string, l+len(p.Tags)) On 2016/12/22 01:46:10, seanmccullough1 wrote: ...
3 years, 12 months ago (2016-12-22 01:49:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2595993002/20001
3 years, 12 months ago (2016-12-22 01:50:31 UTC) #8
commit-bot: I haz the power
3 years, 12 months ago (2016-12-22 01:56:29 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/294de93752002bee56028b1138c2c58d0837a97d

Powered by Google App Engine
This is Rietveld 408576698