Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 2595943003: Null check secondary_pointer_down_event_ (Closed)

Created:
3 years, 12 months ago by boliu
Modified:
3 years, 11 months ago
Reviewers:
tdresser
CC:
chromium-reviews, tdresser+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Null check secondary_pointer_down_event_ There are some crash reports in android webview that suggests this pointer is null and used. In android webview, the app gets the touch events first, so can modify or drop events however they want. That may be the reason certain assumptions holds in chrome, but not in webview. Assuming that's the case, just add null checks before use. BUG=675772 Committed: https://crrev.com/f701a9837b92d3259e9792c24a9de338fb9d8352 Cr-Commit-Position: refs/heads/master@{#440960}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M ui/events/gesture_detection/gesture_detector.cc View 3 chunks +9 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
boliu
ptal, bug has more context
3 years, 12 months ago (2016-12-21 19:29:33 UTC) #2
tdresser
LGTM as a short term fix. Let's still try to identify cases where WebView is ...
3 years, 12 months ago (2016-12-24 15:18:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2595943003/1
3 years, 11 months ago (2016-12-29 15:43:09 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2016-12-29 16:26:02 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:52:25 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f701a9837b92d3259e9792c24a9de338fb9d8352
Cr-Commit-Position: refs/heads/master@{#440960}

Powered by Google App Engine
This is Rietveld 408576698