Update TaskTraits in platform_keys_nss.cc.

Update TaskTraits in platform_keys_nss.cc.

The .WithFileIO() and .WithWait() traits were deprecated in favor of
.MayBlock() and .WithSyncPrimitives(). See rationale in
https://docs.google.com/a/chromium.org/document/d/1ynRvQKah3Cx_eLqPS7KzIp8u73HeKIjX7HQqwSWOnF8/edit?usp=sharing

.MayBlock()
Tasks with this trait may block. This includes but is not limited to tasks
that wait on synchronous file I/O operations: read or write a file from
disk, interact with a pipe or a socket, rename or delete a file, enumerate
files in a directory, etc. This trait does not allow tasks to wait on
synchronization primitives (thread or process handles, waitable events,
condition variables).

.WithSyncPrimitives()
Tasks with this trait are allowed to block on synchronization primitives
(wait on a waitable event/condition variable, join a process/thread).
This trait implies MayBlock(), i.e. you do not need to specify MayBlock()
for a task that blocks exclusively on synchronization primitives.

R=gab@chromium.org
BUG=675660
Committed: https://crrev.com/75f928276fd3742f1a9b10aefae583743a864768
Cr-Commit-Position: refs/heads/master@{#440217}

[fdoray, 2016-12-21 15:47:28]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 15:47:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fdoray, 2016-12-21 16:06:09]

fdoray@chromium.org changed reviewers:
+ emaxx@chromium.org

[fdoray, 2016-12-21 16:06:09]

PTAL

[gab, 2016-12-21 16:08:24]

lgtm

[commit-bot: I haz the power, 2016-12-21 18:05:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 18:05:52]

Dry run: This issue passed the CQ dry run.

[emaxx, 2016-12-21 20:41:44]

Giving LGTM as it's anyway up to you to decide which flag is more appropriate
here, given all the information (please see below).


The discussed code in platform_keys_nss.cc performs crypto-related operations
against TPM. It does that using the NSS library. This happens by sending the
requests to chapsd daemon over D-BUS and (synchronously) reading their results:
https://sites.google.com/a/chromium.org/dev/developers/design-documents/chaps...

So the question now is: how should the synchronous D-BUS requests be qualified -
as MayBlock or as WithSyncPrimitives?
It's not clear to me - on one side, D-BUS is built (if I'm not mistaken) on top
of domain sockets, but on the other side the reasons why would some
synchronization primitives be needed here can be easily imagined.


But I guess the situation here is not much different from several other parts of
Chrome that also use D-BUS - e.g. for communicating with session manager or with
network manager (shill).

[fdoray, 2016-12-21 21:14:30]

The CQ bit was checked by fdoray@chromium.org

[commit-bot: I haz the power, 2016-12-21 21:15:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 21:21:42]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1482354870054960, "parent_rev":
"9ea50f9b28fa98051ead69e55ff9a15585276599", "commit_rev":
"b2f20f0b7173568178e9b7be29c353c7be910219"}

[commit-bot: I haz the power, 2016-12-21 21:22:09]

Description was changed from

==========
Update TaskTraits in platform_keys_nss.cc.

The .WithFileIO() and .WithWait() traits were deprecated in favor of
.MayBlock() and .WithSyncPrimitives(). See rationale in
https://docs.google.com/a/chromium.org/document/d/1ynRvQKah3Cx_eLqPS7KzIp8u73...

.MayBlock()
Tasks with this trait may block. This includes but is not limited to tasks
that wait on synchronous file I/O operations: read or write a file from
disk, interact with a pipe or a socket, rename or delete a file, enumerate
files in a directory, etc. This trait does not allow tasks to wait on
synchronization primitives (thread or process handles, waitable events,
condition variables).

.WithSyncPrimitives()
Tasks with this trait are allowed to block on synchronization primitives
(wait on a waitable event/condition variable, join a process/thread).
This trait implies MayBlock(), i.e. you do not need to specify MayBlock()
for a task that blocks exclusively on synchronization primitives.

R=gab@chromium.org
BUG=675660
==========

to

==========
Update TaskTraits in platform_keys_nss.cc.

The .WithFileIO() and .WithWait() traits were deprecated in favor of
.MayBlock() and .WithSyncPrimitives(). See rationale in
https://docs.google.com/a/chromium.org/document/d/1ynRvQKah3Cx_eLqPS7KzIp8u73...

.MayBlock()
Tasks with this trait may block. This includes but is not limited to tasks
that wait on synchronous file I/O operations: read or write a file from
disk, interact with a pipe or a socket, rename or delete a file, enumerate
files in a directory, etc. This trait does not allow tasks to wait on
synchronization primitives (thread or process handles, waitable events,
condition variables).

.WithSyncPrimitives()
Tasks with this trait are allowed to block on synchronization primitives
(wait on a waitable event/condition variable, join a process/thread).
This trait implies MayBlock(), i.e. you do not need to specify MayBlock()
for a task that blocks exclusively on synchronization primitives.

R=gab@chromium.org
BUG=675660

Review-Url: https://codereview.chromium.org/2595903002
==========

[commit-bot: I haz the power, 2016-12-21 21:22:12]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-21 21:26:21]

Description was changed from

==========
Update TaskTraits in platform_keys_nss.cc.

The .WithFileIO() and .WithWait() traits were deprecated in favor of
.MayBlock() and .WithSyncPrimitives(). See rationale in
https://docs.google.com/a/chromium.org/document/d/1ynRvQKah3Cx_eLqPS7KzIp8u73...

.MayBlock()
Tasks with this trait may block. This includes but is not limited to tasks
that wait on synchronous file I/O operations: read or write a file from
disk, interact with a pipe or a socket, rename or delete a file, enumerate
files in a directory, etc. This trait does not allow tasks to wait on
synchronization primitives (thread or process handles, waitable events,
condition variables).

.WithSyncPrimitives()
Tasks with this trait are allowed to block on synchronization primitives
(wait on a waitable event/condition variable, join a process/thread).
This trait implies MayBlock(), i.e. you do not need to specify MayBlock()
for a task that blocks exclusively on synchronization primitives.

R=gab@chromium.org
BUG=675660

Review-Url: https://codereview.chromium.org/2595903002
==========

to

==========
Update TaskTraits in platform_keys_nss.cc.

The .WithFileIO() and .WithWait() traits were deprecated in favor of
.MayBlock() and .WithSyncPrimitives(). See rationale in
https://docs.google.com/a/chromium.org/document/d/1ynRvQKah3Cx_eLqPS7KzIp8u73...

.MayBlock()
Tasks with this trait may block. This includes but is not limited to tasks
that wait on synchronous file I/O operations: read or write a file from
disk, interact with a pipe or a socket, rename or delete a file, enumerate
files in a directory, etc. This trait does not allow tasks to wait on
synchronization primitives (thread or process handles, waitable events,
condition variables).

.WithSyncPrimitives()
Tasks with this trait are allowed to block on synchronization primitives
(wait on a waitable event/condition variable, join a process/thread).
This trait implies MayBlock(), i.e. you do not need to specify MayBlock()
for a task that blocks exclusively on synchronization primitives.

R=gab@chromium.org
BUG=675660

Committed: https://crrev.com/75f928276fd3742f1a9b10aefae583743a864768
Cr-Commit-Position: refs/heads/master@{#440217}
==========

[commit-bot: I haz the power, 2016-12-21 21:26:22]

Patchset 1 (id:??) landed as
https://crrev.com/75f928276fd3742f1a9b10aefae583743a864768
Cr-Commit-Position: refs/heads/master@{#440217}