Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 2595893002: [runtime] Remove specific Descriptor subclasses and add respective factory methods instead. (Closed)

Created:
4 years ago by Igor Sheludko
Modified:
4 years ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Remove specific Descriptor subclasses and add respective factory methods instead. This is a preliminary step for constant tracking. BUG=v8:5495 Review-Url: https://codereview.chromium.org/2595893002 Cr-Commit-Position: refs/heads/master@{#41899} Committed: https://chromium.googlesource.com/v8/v8/+/7cd573f4390d5840a3e2816dd8d294a8843b3d68

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+201 lines, -196 lines) Patch
M src/bootstrapper.cc View 28 chunks +99 lines, -92 lines 0 comments Download
M src/factory.cc View 8 chunks +20 lines, -20 lines 0 comments Download
M src/objects.cc View 10 chunks +30 lines, -25 lines 0 comments Download
M src/property.h View 3 chunks +26 lines, -36 lines 0 comments Download
M src/property.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M test/cctest/heap/test-alloc.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-field-type-tracking.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M test/cctest/test-unboxed-doubles.cc View 2 chunks +12 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Igor Sheludko
PTAL
4 years ago (2016-12-21 15:50:20 UTC) #2
mvstanton
lgtm
4 years ago (2016-12-21 15:51:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2595893002/1
4 years ago (2016-12-21 15:54:07 UTC) #5
commit-bot: I haz the power
4 years ago (2016-12-21 16:40:07 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/7cd573f4390d5840a3e2816dd8d294a8843...

Powered by Google App Engine
This is Rietveld 408576698