Revert of [Mojo Video Capture] Decouple VCController from VCBufferPool and VCDeviceClient

Revert of [Mojo Video Capture] Decouple VCController from VCBufferPool and VCDeviceClient (patchset #4 id:100001 of https://codereview.chromium.org/2551193002/ )

Reason for revert:
This caused a regression where video capture on Android would get stuck in a loop when putting the browser to the background and restoring.
See crbug.com/675528 for details.

Original issue's description:
> [Mojo Video Capture] Decouple VideoCaptureController from VideoCaptureBufferPool and VideoCaptureDeviceClient
>
> Decouple VideoCaptureController from VideoCaptureBufferPool and
> VideoCaptureDeviceClient. This is needed in order to prepare
> VideoCaptureController for working with both the (legacy) in-process video
> capture and the new video_capture Mojo service.
>
> List of changes:
> * Introduce an abstraction FrameBufferHost for the VideoCaptureController to
>   talk to the VideoCaptureBufferPool.
> * Move VideoFrameReceiverOnIOThread to separate file.
> * Move factory logic for creating and connecting
>   VideoCaptureBufferPoolImpl and VideoCaptureDeviceClient out of
>   VideoCaptureController and into VideoCaptureManager as well as the tests.
> * Update OWNERS to include new file and include chfremer as owner.
> * In VideoCaptureDeviceClient: Rename |frame_format| to |foramt|.
>
> This CL is part of the Mojo Video Capture work. For the bigger picture,
> see [1] CL1.9.8
>
> BUG=584797
> TEST=
>   content_unittests,
>   video_capture_unittests,
>   Apprtc loopback on Debug,
>   Desktop Capture Example extension on Release
>
> [1] https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxsxWslJ_X-zpOhijvI8/edit?usp=sharing
>
> Committed: https://crrev.com/0b129bdbdd3099a492bcf014c22239c2b35071a2
> Cr-Commit-Position: refs/heads/master@{#438604}

TBR=mcasas@chromium.org,miu@chromium.org,avi@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=584797
Committed: https://crrev.com/78026a02b0b54c508d1e25b62b7beac2807af660
Cr-Commit-Position: refs/heads/master@{#440226}

[chfremer, 2016-12-21 19:50:48]

The CQ bit was checked by chfremer@chromium.org

[chfremer, 2016-12-21 19:50:48]

Created Revert of [Mojo Video Capture] Decouple VCController from VCBufferPool
and VCDeviceClient

[commit-bot: I haz the power, 2016-12-21 19:51:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 21:40:47]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1482349848301150, "parent_rev":
"63fe51f152f37ff48ebb29466a0eb67d9f57a4ab", "commit_rev":
"4c0beaf9a1e66ed7045bb7aca2eb2e970b04460f"}

[commit-bot: I haz the power, 2016-12-21 21:41:19]

Description was changed from

==========
Revert of [Mojo Video Capture] Decouple VCController from VCBufferPool and
VCDeviceClient (patchset #4 id:100001 of
https://codereview.chromium.org/2551193002/ )

Reason for revert:
This caused a regression where video capture on Android would get stuck in a
loop when putting the browser to the background and restoring.
See crbug.com/675528 for details.

Original issue's description:
> [Mojo Video Capture] Decouple VideoCaptureController from
VideoCaptureBufferPool and VideoCaptureDeviceClient
> 
> Decouple VideoCaptureController from VideoCaptureBufferPool and
> VideoCaptureDeviceClient. This is needed in order to prepare
> VideoCaptureController for working with both the (legacy) in-process video
> capture and the new video_capture Mojo service.
> 
> List of changes:
> * Introduce an abstraction FrameBufferHost for the VideoCaptureController to
>   talk to the VideoCaptureBufferPool.
> * Move VideoFrameReceiverOnIOThread to separate file.
> * Move factory logic for creating and connecting
>   VideoCaptureBufferPoolImpl and VideoCaptureDeviceClient out of
>   VideoCaptureController and into VideoCaptureManager as well as the tests.
> * Update OWNERS to include new file and include chfremer as owner.
> * In VideoCaptureDeviceClient: Rename |frame_format| to |foramt|.
> 
> This CL is part of the Mojo Video Capture work. For the bigger picture,
> see [1] CL1.9.8
> 
> BUG=584797
> TEST=
>   content_unittests,
>   video_capture_unittests,
>   Apprtc loopback on Debug,
>   Desktop Capture Example extension on Release
> 
> [1]
https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxs...
> 
> Committed: https://crrev.com/0b129bdbdd3099a492bcf014c22239c2b35071a2
> Cr-Commit-Position: refs/heads/master@{#438604}

TBR=mcasas@chromium.org,miu@chromium.org,avi@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=584797
==========

to

==========
Revert of [Mojo Video Capture] Decouple VCController from VCBufferPool and
VCDeviceClient (patchset #4 id:100001 of
https://codereview.chromium.org/2551193002/ )

Reason for revert:
This caused a regression where video capture on Android would get stuck in a
loop when putting the browser to the background and restoring.
See crbug.com/675528 for details.

Original issue's description:
> [Mojo Video Capture] Decouple VideoCaptureController from
VideoCaptureBufferPool and VideoCaptureDeviceClient
> 
> Decouple VideoCaptureController from VideoCaptureBufferPool and
> VideoCaptureDeviceClient. This is needed in order to prepare
> VideoCaptureController for working with both the (legacy) in-process video
> capture and the new video_capture Mojo service.
> 
> List of changes:
> * Introduce an abstraction FrameBufferHost for the VideoCaptureController to
>   talk to the VideoCaptureBufferPool.
> * Move VideoFrameReceiverOnIOThread to separate file.
> * Move factory logic for creating and connecting
>   VideoCaptureBufferPoolImpl and VideoCaptureDeviceClient out of
>   VideoCaptureController and into VideoCaptureManager as well as the tests.
> * Update OWNERS to include new file and include chfremer as owner.
> * In VideoCaptureDeviceClient: Rename |frame_format| to |foramt|.
> 
> This CL is part of the Mojo Video Capture work. For the bigger picture,
> see [1] CL1.9.8
> 
> BUG=584797
> TEST=
>   content_unittests,
>   video_capture_unittests,
>   Apprtc loopback on Debug,
>   Desktop Capture Example extension on Release
> 
> [1]
https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxs...
> 
> Committed: https://crrev.com/0b129bdbdd3099a492bcf014c22239c2b35071a2
> Cr-Commit-Position: refs/heads/master@{#438604}

TBR=mcasas@chromium.org,miu@chromium.org,avi@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=584797

Review-Url: https://codereview.chromium.org/2595853003
==========

[commit-bot: I haz the power, 2016-12-21 21:41:20]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-21 21:42:57]

Description was changed from

==========
Revert of [Mojo Video Capture] Decouple VCController from VCBufferPool and
VCDeviceClient (patchset #4 id:100001 of
https://codereview.chromium.org/2551193002/ )

Reason for revert:
This caused a regression where video capture on Android would get stuck in a
loop when putting the browser to the background and restoring.
See crbug.com/675528 for details.

Original issue's description:
> [Mojo Video Capture] Decouple VideoCaptureController from
VideoCaptureBufferPool and VideoCaptureDeviceClient
> 
> Decouple VideoCaptureController from VideoCaptureBufferPool and
> VideoCaptureDeviceClient. This is needed in order to prepare
> VideoCaptureController for working with both the (legacy) in-process video
> capture and the new video_capture Mojo service.
> 
> List of changes:
> * Introduce an abstraction FrameBufferHost for the VideoCaptureController to
>   talk to the VideoCaptureBufferPool.
> * Move VideoFrameReceiverOnIOThread to separate file.
> * Move factory logic for creating and connecting
>   VideoCaptureBufferPoolImpl and VideoCaptureDeviceClient out of
>   VideoCaptureController and into VideoCaptureManager as well as the tests.
> * Update OWNERS to include new file and include chfremer as owner.
> * In VideoCaptureDeviceClient: Rename |frame_format| to |foramt|.
> 
> This CL is part of the Mojo Video Capture work. For the bigger picture,
> see [1] CL1.9.8
> 
> BUG=584797
> TEST=
>   content_unittests,
>   video_capture_unittests,
>   Apprtc loopback on Debug,
>   Desktop Capture Example extension on Release
> 
> [1]
https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxs...
> 
> Committed: https://crrev.com/0b129bdbdd3099a492bcf014c22239c2b35071a2
> Cr-Commit-Position: refs/heads/master@{#438604}

TBR=mcasas@chromium.org,miu@chromium.org,avi@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=584797

Review-Url: https://codereview.chromium.org/2595853003
==========

to

==========
Revert of [Mojo Video Capture] Decouple VCController from VCBufferPool and
VCDeviceClient (patchset #4 id:100001 of
https://codereview.chromium.org/2551193002/ )

Reason for revert:
This caused a regression where video capture on Android would get stuck in a
loop when putting the browser to the background and restoring.
See crbug.com/675528 for details.

Original issue's description:
> [Mojo Video Capture] Decouple VideoCaptureController from
VideoCaptureBufferPool and VideoCaptureDeviceClient
>
> Decouple VideoCaptureController from VideoCaptureBufferPool and
> VideoCaptureDeviceClient. This is needed in order to prepare
> VideoCaptureController for working with both the (legacy) in-process video
> capture and the new video_capture Mojo service.
>
> List of changes:
> * Introduce an abstraction FrameBufferHost for the VideoCaptureController to
>   talk to the VideoCaptureBufferPool.
> * Move VideoFrameReceiverOnIOThread to separate file.
> * Move factory logic for creating and connecting
>   VideoCaptureBufferPoolImpl and VideoCaptureDeviceClient out of
>   VideoCaptureController and into VideoCaptureManager as well as the tests.
> * Update OWNERS to include new file and include chfremer as owner.
> * In VideoCaptureDeviceClient: Rename |frame_format| to |foramt|.
>
> This CL is part of the Mojo Video Capture work. For the bigger picture,
> see [1] CL1.9.8
>
> BUG=584797
> TEST=
>   content_unittests,
>   video_capture_unittests,
>   Apprtc loopback on Debug,
>   Desktop Capture Example extension on Release
>
> [1]
https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxs...
>
> Committed: https://crrev.com/0b129bdbdd3099a492bcf014c22239c2b35071a2
> Cr-Commit-Position: refs/heads/master@{#438604}

TBR=mcasas@chromium.org,miu@chromium.org,avi@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=584797

Committed: https://crrev.com/78026a02b0b54c508d1e25b62b7beac2807af660
Cr-Commit-Position: refs/heads/master@{#440226}
==========

[commit-bot: I haz the power, 2016-12-21 21:42:58]

Patchset 1 (id:??) landed as
https://crrev.com/78026a02b0b54c508d1e25b62b7beac2807af660
Cr-Commit-Position: refs/heads/master@{#440226}