Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Unified Diff: third_party/WebKit/LayoutTests/editing/execCommand/justify-center-editable-style-on-child-crash.html

Issue 2595783002: [Editing] Add null check in |DeleteSelectionCommand::removeRedundantBlocks()| (Closed)
Patch Set: xiaochengh's review: Add layout test Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/editing/execCommand/justify-center-editable-style-on-child-crash.html
diff --git a/third_party/WebKit/LayoutTests/editing/execCommand/justify-center-editable-style-on-child-crash.html b/third_party/WebKit/LayoutTests/editing/execCommand/justify-center-editable-style-on-child-crash.html
new file mode 100644
index 0000000000000000000000000000000000000000..88ac63aed81fac6bc1ea0fa83a954a6ffa688c56
--- /dev/null
+++ b/third_party/WebKit/LayoutTests/editing/execCommand/justify-center-editable-style-on-child-crash.html
@@ -0,0 +1,19 @@
+<title>Justify center and remove redounded div wont crash</title>
Xiaocheng 2016/12/22 03:25:51 Could you mentioned the bug number in the layout t
chongz 2016/12/22 05:14:50 Done.
+<script src="../../resources/testharness.js"></script>
+<script src="../../resources/testharnessreport.js"></script>
+<div><div>
+ <div></div>
+ <ul>
+ <li>
+ <div></div>
+ <input>
+ <style> * {-webkit-user-modify: read-write;}</style><div></div>
+ </li>
+ </ul></div></div>
+<script>
+test(() => {
+ const li = document.getElementsByTagName("li")[0];
dominicc (has gone to gerrit) 2016/12/22 03:56:32 If you just do querySelector you'll get the 0th on
chongz 2016/12/22 05:14:50 Done.
+ window.getSelection().collapse(li, 0);
+ document.execCommand('JustifyRight');
+}, 'Justify center and remove redounded div wont crash');
dominicc (has gone to gerrit) 2016/12/22 03:56:32 This description needs some work. Is this Justify,
chongz 2016/12/22 05:14:50 Sorry for the typo... I've added a comment for the
+</script>
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698