Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Side by Side Diff: third_party/WebKit/LayoutTests/editing/execCommand/justify-center-editable-style-on-child-crash.html

Issue 2595783002: [Editing] Add null check in |DeleteSelectionCommand::removeRedundantBlocks()| (Closed)
Patch Set: xiaochengh's review: Add layout test Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 <title>Justify center and remove redounded div wont crash</title>
Xiaocheng 2016/12/22 03:25:51 Could you mentioned the bug number in the layout t
chongz 2016/12/22 05:14:50 Done.
2 <script src="../../resources/testharness.js"></script>
3 <script src="../../resources/testharnessreport.js"></script>
4 <div><div>
5 <div></div>
6 <ul>
7 <li>
8 <div></div>
9 <input>
10 <style> * {-webkit-user-modify: read-write;}</style><div></div>
11 </li>
12 </ul></div></div>
13 <script>
14 test(() => {
15 const li = document.getElementsByTagName("li")[0];
dominicc (has gone to gerrit) 2016/12/22 03:56:32 If you just do querySelector you'll get the 0th on
chongz 2016/12/22 05:14:50 Done.
16 window.getSelection().collapse(li, 0);
17 document.execCommand('JustifyRight');
18 }, 'Justify center and remove redounded div wont crash');
dominicc (has gone to gerrit) 2016/12/22 03:56:32 This description needs some work. Is this Justify,
chongz 2016/12/22 05:14:50 Sorry for the typo... I've added a comment for the
19 </script>
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698