Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 2595733003: [wasm] Remove non-standard kExprI8Const bytecode (Closed)

Created:
4 years ago by titzer
Modified:
3 years, 11 months ago
Reviewers:
Clemens Hammacher
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Remove non-standard kExprI8Const bytecode R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2595733003 Cr-Commit-Position: refs/heads/master@{#42141} Committed: https://chromium.googlesource.com/v8/v8/+/7ed3c4d791b3f67cdf582e83dc9e04baf8bed562

Patch Set 1 #

Total comments: 3

Patch Set 2 : Rebase #

Patch Set 3 : Remove regression test #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+460 lines, -512 lines) Patch
M src/asmjs/asm-wasm-builder.cc View 1 3 chunks +3 lines, -4 lines 0 comments Download
M src/wasm/function-body-decoder.cc View 1 2 chunks +0 lines, -8 lines 0 comments Download
M src/wasm/wasm-interpreter.cc View 1 1 chunk +0 lines, -6 lines 0 comments Download
M src/wasm/wasm-macro-gen.h View 2 chunks +6 lines, -7 lines 0 comments Download
M src/wasm/wasm-module-builder.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/wasm/wasm-opcodes.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/wasm/wasm-text.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/wasm/test-run-wasm.cc View 60 chunks +180 lines, -208 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-64.cc View 6 chunks +15 lines, -16 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-interpreter.cc View 7 chunks +17 lines, -13 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-module.cc View 8 chunks +12 lines, -10 lines 0 comments Download
D test/mjsunit/regress/wasm/665402.wasm View 1 2 Binary file 0 comments Download
M test/mjsunit/regress/wasm/regression-5531.js View 1 1 chunk +2 lines, -2 lines 0 comments Download
D test/mjsunit/regress/wasm/regression-665402.js View 1 2 1 chunk +0 lines, -12 lines 1 comment Download
M test/mjsunit/regress/wasm/regression-667745.js View 1 2 chunks +3 lines, -3 lines 0 comments Download
M test/mjsunit/wasm/compiled-module-serialization.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/wasm/export-table.js View 4 chunks +8 lines, -8 lines 0 comments Download
M test/mjsunit/wasm/ffi.js View 3 chunks +3 lines, -3 lines 0 comments Download
M test/mjsunit/wasm/function-prototype.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/wasm/import-table.js View 3 chunks +4 lines, -4 lines 0 comments Download
M test/mjsunit/wasm/instantiate-module-basic.js View 1 chunk +2 lines, -2 lines 0 comments Download
M test/mjsunit/wasm/instantiate-run-basic.js View 1 chunk +2 lines, -2 lines 0 comments Download
M test/mjsunit/wasm/module-memory.js View 1 chunk +6 lines, -6 lines 0 comments Download
M test/mjsunit/wasm/start-function.js View 3 chunks +4 lines, -4 lines 0 comments Download
M test/mjsunit/wasm/test-wasm-module-builder.js View 4 chunks +4 lines, -4 lines 0 comments Download
M test/mjsunit/wasm/wasm-constants.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/unittests/wasm/control-transfer-unittest.cc View 3 chunks +73 lines, -73 lines 0 comments Download
M test/unittests/wasm/function-body-decoder-unittest.cc View 1 34 chunks +101 lines, -99 lines 0 comments Download
M test/unittests/wasm/loop-assignment-analysis-unittest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M test/unittests/wasm/wasm-macro-gen-unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 21 (16 generated)
titzer
PTAL
4 years ago (2016-12-21 15:22:49 UTC) #3
Clemens Hammacher
lgtm https://codereview.chromium.org/2595733003/diff/1/test/cctest/wasm/test-run-wasm.cc File test/cctest/wasm/test-run-wasm.cc (right): https://codereview.chromium.org/2595733003/diff/1/test/cctest/wasm/test-run-wasm.cc#newcode714 test/cctest/wasm/test-run-wasm.cc:714: BUILD(r, WASM_IF_ELSE_I(WASM_I32V_1(1), // -- WASM_I32V_1(1) can be replaced ...
4 years ago (2016-12-21 15:44:48 UTC) #6
titzer
https://codereview.chromium.org/2595733003/diff/40001/test/mjsunit/regress/wasm/regression-665402.js File test/mjsunit/regress/wasm/regression-665402.js (left): https://codereview.chromium.org/2595733003/diff/40001/test/mjsunit/regress/wasm/regression-665402.js#oldcode12 test/mjsunit/regress/wasm/regression-665402.js:12: assertTrue(module != undefined); Note that I am removing this ...
3 years, 11 months ago (2017-01-09 13:20:49 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2595733003/40001
3 years, 11 months ago (2017-01-09 13:55:48 UTC) #18
commit-bot: I haz the power
3 years, 11 months ago (2017-01-09 13:57:32 UTC) #21
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/7ed3c4d791b3f67cdf582e83dc9e04baf8b...

Powered by Google App Engine
This is Rietveld 408576698