Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 2595713002: Fixed and added Find-in-page tests (Closed)

Created:
4 years ago by shaktisahu
Modified:
4 years ago
Reviewers:
gone
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixed and added Find-in-page tests Fixed a test for Find in page. Also added two new tests to verify behavior on fullscreen mode and prev/next button functionality in case of no match. BUG=676045 Committed: https://crrev.com/29e3616a6cf88269d143d302b3229ece42666065 Cr-Commit-Position: refs/heads/master@{#439945}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -4 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/widget/findinpage/FindTest.java View 3 chunks +43 lines, -4 lines 1 comment Download

Messages

Total messages: 11 (6 generated)
shaktisahu
PTAL https://codereview.chromium.org/2595713002/diff/1/chrome/android/javatests/src/org/chromium/chrome/browser/widget/findinpage/FindTest.java File chrome/android/javatests/src/org/chromium/chrome/browser/widget/findinpage/FindTest.java (left): https://codereview.chromium.org/2595713002/diff/1/chrome/android/javatests/src/org/chromium/chrome/browser/widget/findinpage/FindTest.java#oldcode389 chrome/android/javatests/src/org/chromium/chrome/browser/widget/findinpage/FindTest.java:389: waitForIME(false); This test was failing as a result ...
4 years ago (2016-12-20 23:25:30 UTC) #2
gone
lgtm
4 years ago (2016-12-20 23:29:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2595713002/1
4 years ago (2016-12-20 23:43:01 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-21 00:13:07 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-21 00:17:20 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/29e3616a6cf88269d143d302b3229ece42666065
Cr-Commit-Position: refs/heads/master@{#439945}

Powered by Google App Engine
This is Rietveld 408576698