Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(995)

Issue 2595673002: [profiler] Do not report native function names as script names. (Closed)

Created:
4 years ago by alph
Modified:
4 years ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[profiler] Do not report native function names as script names. BUG=chromium:664286 Review-Url: https://codereview.chromium.org/2595673002 Cr-Commit-Position: refs/heads/master@{#41884} Committed: https://chromium.googlesource.com/v8/v8/+/0f39ef5fdfef3a8d68a05057d2896c52882582a1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M src/code-events.h View 1 chunk +1 line, -1 line 0 comments Download
M src/log.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
alph
4 years ago (2016-12-20 19:56:16 UTC) #2
Yang
lgtm
4 years ago (2016-12-21 07:44:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2595673002/1
4 years ago (2016-12-21 07:50:30 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-21 07:52:12 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/0f39ef5fdfef3a8d68a05057d2896c52882...

Powered by Google App Engine
This is Rietveld 408576698