Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2595633002: Convert Analyser tests to use testharness (Closed)

Created:
3 years, 12 months ago by Raymond Toy
Modified:
3 years, 12 months ago
Reviewers:
hongchan
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert Analyser tests to use testharness The follow bash script converted the tests using Audit to use testharness instead of js-test: for f in `grep -l Audit *.html` do # Replace js-test.js with testharness.js and add testharnessreport.js sed -i 's;\(.*\)\(<script.*\)js-test.js\(.*\);\1\2testharness.js\3\ \1\2testharnessreport.js\3 ;' $f # Remove functions that don't exist anymore. sed -i '/^[ ]*\(description(".*")\|finishJSTest()\);[ ]*/d' $f done However, a few files needed manual adjustment because they used testPassed()/testFailed(), which no longer exists. These were either removed or replaced by Should().summarize(). The expected results files were manually removed. BUG=675987 TEST=Analyser/* passes Committed: https://crrev.com/bdbfd895a9da23367f3d34465b78047cdc1de4e3 Cr-Commit-Position: refs/heads/master@{#440166}

Patch Set 1 #

Total comments: 8

Patch Set 2 : Remove jsTestIsAsync #

Total comments: 1

Patch Set 3 : Remove blank line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -277 lines) Patch
M third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-byte-data.html View 1 2 3 chunks +2 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-byte-data-expected.txt View 1 chunk +0 lines, -14 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-downmix.html View 1 2 4 chunks +5 lines, -9 lines 0 comments Download
D third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-downmix-expected.txt View 1 chunk +0 lines, -29 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-float-data.html View 1 2 7 chunks +11 lines, -26 lines 0 comments Download
D third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-float-data-expected.txt View 1 chunk +0 lines, -64 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-freq-data.html View 1 2 4 chunks +6 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-freq-data-expected.txt View 1 chunk +0 lines, -58 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-freq-data-smoothing.html View 1 2 3 chunks +7 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-freq-data-smoothing-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-multiple-calls.html View 1 2 3 chunks +2 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-multiple-calls-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-zero.html View 1 2 3 chunks +2 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-zero-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 20 (7 generated)
Raymond Toy
PTAL. This is the first conversion to testharness. I plan on following a similar approach ...
3 years, 12 months ago (2016-12-20 17:26:38 UTC) #2
hongchan
On 2016/12/20 17:26:38, Raymond Toy wrote: > PTAL. This is the first conversion to testharness. ...
3 years, 12 months ago (2016-12-20 18:45:42 UTC) #3
Raymond Toy
On 2016/12/20 18:45:42, hongchan wrote: > On 2016/12/20 17:26:38, Raymond Toy wrote: > > PTAL. ...
3 years, 12 months ago (2016-12-20 18:47:41 UTC) #4
hongchan
How about replace 'var ' with 'let ' as a proof of a test file ...
3 years, 12 months ago (2016-12-20 23:04:31 UTC) #6
Raymond Toy
On 2016/12/20 23:04:31, hongchan wrote: > How about replace 'var ' with 'let ' as ...
3 years, 12 months ago (2016-12-20 23:16:57 UTC) #7
blink-reviews
lgtm On Tue, Dec 20, 2016 at 3:16 PM rtoy@chromium.org via codereview.chromium.org <reply@chromiumcodereview-hr.appspotmail.com> wrote: > ...
3 years, 12 months ago (2016-12-20 23:20:54 UTC) #8
chromium-reviews
lgtm On Tue, Dec 20, 2016 at 3:16 PM rtoy@chromium.org via codereview.chromium.org <reply@chromiumcodereview-hr.appspotmail.com> wrote: > ...
3 years, 12 months ago (2016-12-20 23:21:08 UTC) #9
Raymond Toy
https://codereview.chromium.org/2595633002/diff/1/third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-byte-data.html File third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-byte-data.html (right): https://codereview.chromium.org/2595633002/diff/1/third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-byte-data.html#newcode14 third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-byte-data.html:14: window.jsTestIsAsync = true; On 2016/12/20 23:04:30, hongchan wrote: > ...
3 years, 12 months ago (2016-12-21 16:16:33 UTC) #10
hongchan
lgtm with nits https://codereview.chromium.org/2595633002/diff/20001/third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-downmix.html File third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-downmix.html (right): https://codereview.chromium.org/2595633002/diff/20001/third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-downmix.html#newcode16 third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-downmix.html:16: Let's remove this empty line. I ...
3 years, 12 months ago (2016-12-21 16:22:10 UTC) #11
Raymond Toy
On 2016/12/21 16:22:10, hongchan wrote: > lgtm with nits > > https://codereview.chromium.org/2595633002/diff/20001/third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-downmix.html > File > ...
3 years, 12 months ago (2016-12-21 16:23:34 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2595633002/40001
3 years, 12 months ago (2016-12-21 16:42:36 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
3 years, 12 months ago (2016-12-21 18:46:18 UTC) #18
commit-bot: I haz the power
3 years, 12 months ago (2016-12-21 18:48:33 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/bdbfd895a9da23367f3d34465b78047cdc1de4e3
Cr-Commit-Position: refs/heads/master@{#440166}

Powered by Google App Engine
This is Rietveld 408576698