Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Issue 2595603002: Revert of Maintain HostZoom connection per-frame on browser side (Closed)

Created:
4 years ago by blundell
Modified:
4 years ago
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Maintain HostZoom connection per-frame on browser side (patchset #4 id:100001 of https://codereview.chromium.org/2581143002/ ) Reason for revert: Seems to cause problems on Mac: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.webkit%2FWebKit_Mac10.10%2F28001%2F%2B%2Frecipes%2Fsteps%2Fwebkit_tests%2F0%2Fstdout Original issue's description: > Maintain HostZoom connection per-frame on browser side > > HostZoomMapObserver is a per-WebContents class, while the HostZoom Mojo > connection is per-frame. Before this CL, HostZoomMapObserver was > maintaining one HostZoom connection and rebinding it every time a new > RenderFrame was created. This meant that HostZoomMapObserver was > continually losing connections to existing frames. This CL changes > HostZoomMapObserver to maintain one connection per-RenderFrame in a > map indexed by the corresponding RenderFrameHost. > > BUG=673065 > TEST=Visit news.ycombinator.com and increase the zoom level to 175%. > Click the top link. Hit back: news.ycombinator.com should still be > zoomed to 175%. > > Committed: https://crrev.com/8e24b7d133424fb221891601d6254b7df58188d5 > Cr-Commit-Position: refs/heads/master@{#439800} TBR=scottmg@chromium.org,wjmaclean@chromium.org,nick@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=673065 Committed: https://crrev.com/a5ec18806970f9f7a4b2b1f5df55c49b40b2a9ed Cr-Commit-Position: refs/heads/master@{#439810}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -120 lines) Patch
M content/browser/host_zoom_map_observer.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/host_zoom_map_observer.cc View 1 chunk +6 lines, -19 lines 0 comments Download
M content/browser/iframe_zoom_browsertest.cc View 2 chunks +1 line, -68 lines 0 comments Download
D content/test/data/page_with_iframe_and_link.html View 1 chunk +0 lines, -31 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
blundell
Created Revert of Maintain HostZoom connection per-frame on browser side
4 years ago (2016-12-20 15:53:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2595603002/1
4 years ago (2016-12-20 15:54:01 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-20 15:55:11 UTC) #6
commit-bot: I haz the power
4 years ago (2016-12-20 15:56:59 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a5ec18806970f9f7a4b2b1f5df55c49b40b2a9ed
Cr-Commit-Position: refs/heads/master@{#439810}

Powered by Google App Engine
This is Rietveld 408576698