DescriptionRevert of Maintain HostZoom connection per-frame on browser side (patchset #4 id:100001 of https://codereview.chromium.org/2581143002/ )
Reason for revert:
Seems to cause problems on Mac:
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.webkit%2FWebKit_Mac10.10%2F28001%2F%2B%2Frecipes%2Fsteps%2Fwebkit_tests%2F0%2Fstdout
Original issue's description:
> Maintain HostZoom connection per-frame on browser side
>
> HostZoomMapObserver is a per-WebContents class, while the HostZoom Mojo
> connection is per-frame. Before this CL, HostZoomMapObserver was
> maintaining one HostZoom connection and rebinding it every time a new
> RenderFrame was created. This meant that HostZoomMapObserver was
> continually losing connections to existing frames. This CL changes
> HostZoomMapObserver to maintain one connection per-RenderFrame in a
> map indexed by the corresponding RenderFrameHost.
>
> BUG=673065
> TEST=Visit news.ycombinator.com and increase the zoom level to 175%.
> Click the top link. Hit back: news.ycombinator.com should still be
> zoomed to 175%.
>
> Committed: https://crrev.com/8e24b7d133424fb221891601d6254b7df58188d5
> Cr-Commit-Position: refs/heads/master@{#439800}
TBR=scottmg@chromium.org,wjmaclean@chromium.org,nick@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=673065
Committed: https://crrev.com/a5ec18806970f9f7a4b2b1f5df55c49b40b2a9ed
Cr-Commit-Position: refs/heads/master@{#439810}
Patch Set 1 #
Messages
Total messages: 8 (4 generated)
|