Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2595573002:
Remove image name (Closed)
DescriptionRemove image name
This CL removes the image name and add a unique filename with a default PNG
extension. Before this CL the images were named with their filename. But in
order to be saved to the device, the file should have a valid extension.
Revert of the resolution of 656641
BUG=656641, 674555
TEST=Download images with different image type (gif, tiff, bmp, jpg, png)
and verify it is working as expected.
Committed: https://crrev.com/16cfe1ff158f1190e1b26eb1e491409ae904a9b8
Cr-Commit-Position: refs/heads/master@{#440080}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Address nit #Messages
Total messages: 15 (8 generated)
gambard@chromium.org changed reviewers: + pkl@chromium.org
PTAL. This is a revert of https://chromereviews.googleplex.com/527107013/ introducing a bug. The reverted CL tried to get the image extension according to their type but it failed. This CL puts a .png extension to all images, independently of their type. They will still be played as a GIF if they are a GIF for example.
gambard@chromium.org changed reviewers: + marq@chromium.org
marq, PTAL.
LGTM with nit. https://codereview.chromium.org/2595573002/diff/1/ios/chrome/browser/ui/brows... File ios/chrome/browser/ui/browser_view_controller.mm (right): https://codereview.chromium.org/2595573002/diff/1/ios/chrome/browser/ui/brows... ios/chrome/browser/ui/browser_view_controller.mm:3095: NSString* fileName = [NSString nit: If you're just concatenating strings you can use -stringByappendingString: [[[NSProcessInfo processInfo] globallyUniqueString] stringByAppendingString:@".png"];
Thanks! https://codereview.chromium.org/2595573002/diff/1/ios/chrome/browser/ui/brows... File ios/chrome/browser/ui/browser_view_controller.mm (right): https://codereview.chromium.org/2595573002/diff/1/ios/chrome/browser/ui/brows... ios/chrome/browser/ui/browser_view_controller.mm:3095: NSString* fileName = [NSString On 2016/12/21 08:47:00, marq wrote: > nit: If you're just concatenating strings you can use -stringByappendingString: > > [[[NSProcessInfo processInfo] globallyUniqueString] > stringByAppendingString:@".png"]; Done.
The CQ bit was checked by gambard@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from marq@chromium.org Link to the patchset: https://codereview.chromium.org/2595573002/#ps20001 (title: "Address nit")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Remove image name This CL removes the image name and add a unique filename with a default PNG extension. Before this CL the images were named with their filename. But in order to be saved to the device, the file should have a valid extension. Revert of the resolution of 656641 BUG=656641, 674555 ========== to ========== Remove image name This CL removes the image name and add a unique filename with a default PNG extension. Before this CL the images were named with their filename. But in order to be saved to the device, the file should have a valid extension. Revert of the resolution of 656641 BUG=656641, 674555 TEST=Download images with different image type (gif, tiff, bmp, jpg, png) and verify it is working as expected. ==========
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482325335711930,
"parent_rev": "3d2a6ddb83b498ca3932244f04d66da14a0b65a2", "commit_rev":
"0f0a8e9725bcd1f048213a72023f20a8c345be83"}
Message was sent while issue was closed.
Description was changed from ========== Remove image name This CL removes the image name and add a unique filename with a default PNG extension. Before this CL the images were named with their filename. But in order to be saved to the device, the file should have a valid extension. Revert of the resolution of 656641 BUG=656641, 674555 TEST=Download images with different image type (gif, tiff, bmp, jpg, png) and verify it is working as expected. ========== to ========== Remove image name This CL removes the image name and add a unique filename with a default PNG extension. Before this CL the images were named with their filename. But in order to be saved to the device, the file should have a valid extension. Revert of the resolution of 656641 BUG=656641, 674555 TEST=Download images with different image type (gif, tiff, bmp, jpg, png) and verify it is working as expected. Review-Url: https://codereview.chromium.org/2595573002 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Remove image name This CL removes the image name and add a unique filename with a default PNG extension. Before this CL the images were named with their filename. But in order to be saved to the device, the file should have a valid extension. Revert of the resolution of 656641 BUG=656641, 674555 TEST=Download images with different image type (gif, tiff, bmp, jpg, png) and verify it is working as expected. Review-Url: https://codereview.chromium.org/2595573002 ========== to ========== Remove image name This CL removes the image name and add a unique filename with a default PNG extension. Before this CL the images were named with their filename. But in order to be saved to the device, the file should have a valid extension. Revert of the resolution of 656641 BUG=656641, 674555 TEST=Download images with different image type (gif, tiff, bmp, jpg, png) and verify it is working as expected. Committed: https://crrev.com/16cfe1ff158f1190e1b26eb1e491409ae904a9b8 Cr-Commit-Position: refs/heads/master@{#440080} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/16cfe1ff158f1190e1b26eb1e491409ae904a9b8 Cr-Commit-Position: refs/heads/master@{#440080} |
