third_party/WebKit/Source/bindings/core/v8/V8PagePopupControllerBinding.cpp - Issue 2595543003: Rename toV8(...) function in Blink to ToV8(...).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8PagePopupControllerBinding.cpp

Issue 2595543003: Rename toV8(...) function in Blink to ToV8(...). (Closed)

Patch Set: Rebasing... Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8ObjectBuilder.h ('k') | third_party/WebKit/Source/bindings/core/v8/V8ResizeObserverCallbackCustom.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/V8PagePopupControllerBinding.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8PagePopupControllerBinding.cpp b/third_party/WebKit/Source/bindings/core/v8/V8PagePopupControllerBinding.cpp

index e9af66631367117f54e96501699cc44baabb46eb..e6d1e5772cc80a526c67b01d0a9ec7cc22451327 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8PagePopupControllerBinding.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/V8PagePopupControllerBinding.cpp

@@ -24,7 +24,7 @@ void pagePopupControllerAttributeGetter(

DOMWindow* impl = V8Window::toImpl(holder);

PagePopupController* cppValue = PagePopupSupplement::pagePopupController(

*toLocalDOMWindow(impl)->frame());

- v8SetReturnValue(info, toV8(cppValue, holder, info.GetIsolate()));

+ v8SetReturnValue(info, ToV8(cppValue, holder, info.GetIsolate()));

}

void pagePopupControllerAttributeGetterCallback(