pkg/compiler/lib/src/js_emitter/startup_emitter/emitter.dart - Issue 2595493002: Merge CoreTypes and CoreClasses into CommonElements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_emitter/startup_emitter/emitter.dart

Issue 2595493002: Merge CoreTypes and CoreClasses into CommonElements. (Closed)

Patch Set: Updated cf. comment Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/js_emitter/startup_emitter/emitter.dart

diff --git a/pkg/compiler/lib/src/js_emitter/startup_emitter/emitter.dart b/pkg/compiler/lib/src/js_emitter/startup_emitter/emitter.dart

index bac4f1e2aadc862728da3cfd688d8fd07d9d1d22..617fea3170e63a20f05fde19886b524ac7571f41 100644

--- a/pkg/compiler/lib/src/js_emitter/startup_emitter/emitter.dart

+++ b/pkg/compiler/lib/src/js_emitter/startup_emitter/emitter.dart

@@ -146,7 +146,7 @@ class Emitter implements emitterTask.Emitter {

switch (builtin) {

case JsBuiltin.dartObjectConstructor:

return js.js.expressionTemplateYielding(

- typeAccess(_compiler.coreClasses.objectClass));

+ typeAccess(_compiler.commonElements.objectClass));

case JsBuiltin.isCheckPropertyToJsConstructorName:

int isPrefixLength = namer.operatorIsPrefix.length;