Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 259543002: Include wifi_component only when in Win or Mac platforms. (Closed)

Created:
6 years, 8 months ago by tfarina
Modified:
6 years, 8 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Include wifi_component only when in Win or Mac platforms. This issue was found while doing https://codereview.chromium.org/243343002 and we discovered that android was building wifi_test target. It was building this target because it does: $ ninja -C out/Debug -j50 And that builds all the targets generated by gyp. Since the target was not excluded from android platform, a target was created there and thus the above command would build it. This patch fixes this problem, by only including it where it is actually supported. BUG=None TEST=green trybots R=mef@chromium.org,thestig@chromium.org TBR=jochen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266025

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M chrome/chrome.gyp View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/chrome_browser_extensions.gypi View 2 chunks +3 lines, -1 line 0 comments Download
M components/components.gyp View 1 chunk +4 lines, -0 lines 0 comments Download
M components/wifi.gypi View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
tfarina
Lei, could you review my changes in chrome? Mef, could you review everything, but specially ...
6 years, 8 months ago (2014-04-24 03:24:38 UTC) #1
Lei Zhang
Will we have a Linux or ChromeOS implementation in the near future, or is it ...
6 years, 8 months ago (2014-04-24 03:30:11 UTC) #2
mef
On 2014/04/24 03:30:11, Lei Zhang wrote: > Will we have a Linux or ChromeOS implementation ...
6 years, 8 months ago (2014-04-24 03:35:32 UTC) #3
mef
On 2014/04/24 03:30:11, Lei Zhang wrote: > Will we have a Linux or ChromeOS implementation ...
6 years, 8 months ago (2014-04-24 03:35:34 UTC) #4
Lei Zhang
Then chrome/ lgtm
6 years, 8 months ago (2014-04-24 03:36:47 UTC) #5
mef
components/ lgtm. Thanks for doing this!
6 years, 8 months ago (2014-04-24 15:10:32 UTC) #6
tfarina
TBRing jochen for components/
6 years, 8 months ago (2014-04-24 15:52:54 UTC) #7
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 8 months ago (2014-04-24 15:53:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/259543002/1
6 years, 8 months ago (2014-04-24 15:54:29 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 16:59:30 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-04-24 16:59:30 UTC) #11
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 8 months ago (2014-04-24 17:02:59 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/259543002/1
6 years, 8 months ago (2014-04-24 17:05:02 UTC) #13
commit-bot: I haz the power
6 years, 8 months ago (2014-04-24 23:04:36 UTC) #14
Message was sent while issue was closed.
Change committed as 266025

Powered by Google App Engine
This is Rietveld 408576698