Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 2595423002: [promises] Check if receiver is smi before loading map (Closed)

Created:
4 years ago by gsathya
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[promises] Check if receiver is smi before loading map BUG=v8:5343 Review-Url: https://codereview.chromium.org/2595423002 Cr-Commit-Position: refs/heads/master@{#41930} Committed: https://chromium.googlesource.com/v8/v8/+/d5b62384c3aa62c6d76297e9756c073a9c57aa66

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/builtins/builtins-promise.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
gsathya
4 years ago (2016-12-22 19:01:24 UTC) #5
Dan Ehrenberg
lgtm
4 years ago (2016-12-22 19:12:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2595423002/1
4 years ago (2016-12-22 19:25:03 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-22 19:27:14 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/d5b62384c3aa62c6d76297e9756c073a9c5...

Powered by Google App Engine
This is Rietveld 408576698