[stubs] Port LoadFieldStub to TF

[stubs] Port LoadFieldStub to TF

LoadFieldStub is the last Crankshaft/Hydrogen stub that stands in the way
of being able to run --ignition-staging --turbo without any Crankshaft support,
even for ICs/stubs.

Review-Url: https://codereview.chromium.org/2595343002
Cr-Commit-Position: refs/heads/master@{#41939}
Committed: https://chromium.googlesource.com/v8/v8/+/6236060c9caada46a3e6ec6b9c13978d72a43e4e

[danno, 2016-12-22 12:57:55]

The CQ bit was checked by danno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-22 12:58:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 13:24:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-22 13:24:48]

Dry run: This issue passed the CQ dry run.

[danno, 2016-12-22 15:02:44]

The CQ bit was checked by danno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-22 15:02:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danno, 2016-12-22 15:03:12]

danno@chromium.org changed reviewers:
+ ishell@chromium.org, jkummerow@chromium.org

[danno, 2016-12-22 15:03:12]

PTAL

[commit-bot: I haz the power, 2016-12-22 15:23:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-22 15:23:20]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_avx2_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng_trig...)

[Igor Sheludko, 2016-12-22 15:48:14]

lgtm with nits:

https://codereview.chromium.org/2595343002/diff/20001/src/ic/accessor-assembl...
File src/ic/accessor-assembler.cc (right):

https://codereview.chromium.org/2595343002/diff/20001/src/ic/accessor-assembl...
src/ic/accessor-assembler.cc:1669: &miss, kOnlyProperties);
I think we should pass nullptr instead of miss label because we never jump to it
when kOnlyProperties is provided. Unused labels make CSA unhappy.

And please remove the new abort reason.

[Igor Sheludko, 2016-12-22 15:53:59]

https://codereview.chromium.org/2595343002/diff/20001/src/code-stubs.h
File src/code-stubs.h (right):

https://codereview.chromium.org/2595343002/diff/20001/src/code-stubs.h#newcod...
src/code-stubs.h:1172: minor_key_ = 0;
Please remove this. CodeStub initializes minor_key_.

[danno, 2016-12-22 17:20:11]

The CQ bit was checked by danno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-22 17:20:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danno, 2016-12-22 17:24:50]

The CQ bit was checked by danno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-22 17:24:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 17:44:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-22 17:44:24]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)

[danno, 2016-12-23 11:02:51]

The CQ bit was checked by danno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-23 11:02:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-23 11:29:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-23 11:29:24]

Dry run: This issue passed the CQ dry run.

[danno, 2016-12-23 11:58:37]

Description was changed from

==========
[stubs] Port LoadFieldStub to TF
==========

to

==========
[stubs] Port LoadFieldStub to TF

LoadFieldStub is the last Crankshaft/Hydrogen stub that stands in the way
of being able to run --ignition-staging --turbo without any Crankshaft support,
even for ICs/stubs.
==========

[danno, 2016-12-23 11:59:38]

The CQ bit was checked by danno@chromium.org

[danno, 2016-12-23 11:59:38]

The patchset sent to the CQ was uploaded after l-g-t-m from ishell@chromium.org
Link to the patchset: https://codereview.chromium.org/2595343002/#ps100001
(title: "Remerge")

[commit-bot: I haz the power, 2016-12-23 11:59:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-23 12:01:27]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1482494378245610,
"parent_rev": "c42bbec953a962d9900701e322559d1f9ec8029d", "commit_rev":
"6236060c9caada46a3e6ec6b9c13978d72a43e4e"}

[commit-bot: I haz the power, 2016-12-23 12:01:32]

Description was changed from

==========
[stubs] Port LoadFieldStub to TF

LoadFieldStub is the last Crankshaft/Hydrogen stub that stands in the way
of being able to run --ignition-staging --turbo without any Crankshaft support,
even for ICs/stubs.
==========

to

==========
[stubs] Port LoadFieldStub to TF

LoadFieldStub is the last Crankshaft/Hydrogen stub that stands in the way
of being able to run --ignition-staging --turbo without any Crankshaft support,
even for ICs/stubs.

Review-Url: https://codereview.chromium.org/2595343002
Cr-Commit-Position: refs/heads/master@{#41939}
Committed:
https://chromium.googlesource.com/v8/v8/+/6236060c9caada46a3e6ec6b9c13978d72a...
==========

[commit-bot: I haz the power, 2016-12-23 12:01:33]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/v8/v8/+/6236060c9caada46a3e6ec6b9c13978d72a...

[danno, 2016-12-28 16:14:14]

landed

https://codereview.chromium.org/2595343002/diff/20001/src/code-stubs.h
File src/code-stubs.h (right):

https://codereview.chromium.org/2595343002/diff/20001/src/code-stubs.h#newcod...
src/code-stubs.h:1172: minor_key_ = 0;
On 2016/12/22 15:53:59, Igor Sheludko wrote:
> Please remove this. CodeStub initializes minor_key_.

Done.

https://codereview.chromium.org/2595343002/diff/20001/src/ic/accessor-assembl...
File src/ic/accessor-assembler.cc (right):

https://codereview.chromium.org/2595343002/diff/20001/src/ic/accessor-assembl...
src/ic/accessor-assembler.cc:1669: &miss, kOnlyProperties);
On 2016/12/22 15:48:14, Igor Sheludko wrote:
> I think we should pass nullptr instead of miss label because we never jump to
it
> when kOnlyProperties is provided. Unused labels make CSA unhappy.
> 
> And please remove the new abort reason.

Done.